db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3663) Convert store/streamingColumn to JUnit
Date Fri, 23 May 2008 07:27:56 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599293#action_12599293
] 

Kristian Waagan commented on DERBY-3663:
----------------------------------------

Now, this is a big test!

I had a look, and found two things that should be fixed:
 a) Change the class name in the license header.
 b) Replace all tabs with spaces (4 spaces per tab for indentation).

Regarding point b, there are tabs both at the beginning of the lines and elsewhere. There
are also a few occurrences of trailing whitespace on some lines.

Maybe I get some time to look more in detail at the tests themselves later, after you have
addressed the comments from Kathey.
Keep up the good work :)

> Convert store/streamingColumn to JUnit
> --------------------------------------
>
>                 Key: DERBY-3663
>                 URL: https://issues.apache.org/jira/browse/DERBY-3663
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Suran Jayathilaka
>            Assignee: Suran Jayathilaka
>         Attachments: derby-3663-1.diff
>
>
> Convert org.apache.derbyTesting.functionTests.tests.store.streamingColumn to a JUnit
testcase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message