db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2514) convert lang/closed.java to junit
Date Wed, 28 May 2008 09:47:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600419#action_12600419
] 

V.Narayanan commented on DERBY-2514:
------------------------------------

Not removing lang/closed.java is OK, No problem, It can be removed later also once people
are happy with coverage.

I personally have qualms about Derby2514.java either. I am OK with you having used a junit
test case
to add these tests and I think Myrna will be Ok also from what I read of her comments.

About the ICLA, I think this patch is small too, I will commit it once I review it in detail

It is just that this is my first commit and I am a little tensed about it and want to give
it a detailed look. I think
at first look you have done a great job with the coding. It looks very neat and organized.

Thank you for the re attach.

> convert lang/closed.java to junit
> ---------------------------------
>
>                 Key: DERBY-2514
>                 URL: https://issues.apache.org/jira/browse/DERBY-2514
>             Project: Derby
>          Issue Type: Test
>          Components: Newcomer, Test
>         Environment: convert lang/closed.java to junit
>            Reporter: Ramandeep Kaur
>            Assignee: Svein Erik Løvland
>            Priority: Minor
>         Attachments: Derby2514.diff, Derby2514_2.diff
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message