db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3531) DatabasePermission uses a JDK 1.4 method that is not present in J2ME/CDC/Foundation.
Date Thu, 29 May 2008 11:58:45 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12600750#action_12600750
] 

Kristian Waagan commented on DERBY-3531:
----------------------------------------

I ran the test 'SystemPrivilegesPermissionTest.java' on a Java ME platform without failures:
Product: phoneME Advanced (phoneme_advanced_mr2-b34)
Profile: Personal Basis Profile Specification 1.1
JVM:     CVM phoneme_advanced_mr2-b34 (interpreter loop)

I'm also running suites.All there, but expect it will be a while before it has completed (if
I manage to run through it).

Some general comments on the patch:
 1) Inconsistent use of tabs and spaces. According to our guidelines spaces only are preferred,
at least for newly added code.
 2) EmbedConnection.checkDatabaseCreatePrivileges: Is JavaDoc for '@param user' correct? (it
mentions shutdown)
 3) Isn't the comment below actually in SystemPrivilegesPermissionTest.policy? Missing the
digit 1 at the end?

+// PLEASE NOTE WHEN EDITING: This policy file is almost identical to
+//     SystemPrivilegesPermissionTest.policy

My review was only partial, and I know very little about this subject, so another pair of
eyes wouldn't hurt :)

Thanks for the patch!

> DatabasePermission uses a JDK 1.4 method that is not present in J2ME/CDC/Foundation.
> ------------------------------------------------------------------------------------
>
>                 Key: DERBY-3531
>                 URL: https://issues.apache.org/jira/browse/DERBY-3531
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Security
>            Reporter: Daniel John Debrunner
>            Assignee: Martin Zaun
>         Attachments: DERBY-3531-0.diff, DERBY-3531-0.stat
>
>
> causes abstract method errors once the class is used to check for database creation.
> From memory the method is String.split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message