db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Myrna van Lunteren (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3659) revive tests with ldap references to be runnable as junit tests
Date Sat, 31 May 2008 01:28:45 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Myrna van Lunteren updated DERBY-3659:
--------------------------------------

    Attachment: DERBY-3659_2b.diff

attaching a second version of the patch.
I answered my two questions myself:
re InvalidLDAPAuthenticationServerTest - the failed connection attempts apparently caused
the test to cling to the db.lck. I resolved the cleanup trouble by using a singleUseDatabaseDecoratorNoShutdown
instead of singlueUseDatabaseDecorator - now the teardown doesn't attempt to connect &
the cleanup runs smoothly.
re LDAPAuthenticationTest system shutdowns: the original out file was created using a derby.properties
file that set requireAuthentication to true - that's why the shutdown with non-system users
failed. This is already tested in AuthenticationTest, and isn't testing LDAP per se, so I
felt it ok to remove it from the LDAP test.
I added the tests to jdbcapi/_Suite.java with an if block to ensure the ldapServer property
is specified.
I am not sure how to force a more useful message to pop up. For now, if people don't set the
derbyTesting.ldapServer, derbyTesting.ldapUser, derbyTesting.ldapPassword, derbyTesting.dnString,
derbyTesting.ldapPort properties, the test will do nothing, which means no worse test coverage
than we had before.
When the properties are set, and the extra user (kathy/kathyS) is specified, the test will
run.


> revive tests with ldap references to be runnable as junit tests
> ---------------------------------------------------------------
>
>                 Key: DERBY-3659
>                 URL: https://issues.apache.org/jira/browse/DERBY-3659
>             Project: Derby
>          Issue Type: Test
>          Components: Test
>            Reporter: Myrna van Lunteren
>            Assignee: Myrna van Lunteren
>            Priority: Minor
>         Attachments: DERBY-3659.diff, DERBY-3659_2.diff, DERBY-3659_2b.diff
>
>
> During initial contribution some tests were created with references to ldap security
mechanism.
> However, because we don't have ourselves setup for a public ldap server, these tests
have fallen by the wayside.
> Specifically, there is still a secureUsers .out file in functionTests.master that uses
some ldap references, and there's the -not running - jdbcapi.xaJNDI.java.
> These should be turned into junit tests out of these that take properties for the ldapserver,
port, and dnString.
> If we ever get a Zone, with an ldap server, or somehow get access to another public ldap
server, then we can modify the tests to have the correct references.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message