db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kim Haase (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3668) Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes as needed
Date Tue, 20 May 2008 17:17:55 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kim Haase updated DERBY-3668:
-----------------------------

    Attachment: DERBY-3668-2.stat
                DERBY-3668-2.zip
                DERBY-3668-2.diff

Thanks very much, Dag, for these comments. I hope I'm addressing them all right with these
new files: DERBY-3668-2.diff, DERBY-3668-2.zip, and DERBY-3668-2.stat.

About nested savepoints: I added a sentence to "Using savepoints" to say that nested savepoints
are permitted, but only in an embedded environment. Will that be enough?

About the following:

> A savepoint can be reused after it has been released explicitly (by issuing a release
of the savepoint) or implicitly (by issuing a connection commit/rollback).

Or, possibly, if a savepoint has been made invalid due to rolling back to a savepoint declared
earlier than that savepoint? (I didnt test it....)

I think that "implicitly" may cover this situation. However, maybe it is clearer if the sentence
says "implicitly (by issuing a connection commit/rollback to that savepoint or to a savepoint
declared earlier than that savepoint)."


About the "Derby and standards" topic: these corrections are off the JDBC 3.0 topic and in
theory ought to have a separate JIRA -- but it is simpler just to make the corrections now,
so I'm doing that. I added "or newer" to the first sentence and removed the list item "Unique
constraints and nulls".


About "Using auto-commit" and its table: I'm ignorant about cursors so I need a sanity check
here. You say, "But the statement that updatable cursors don't work under autocommit isnt
quite right. If holdable cursors are used, forward only cursors just need a repositioning
to work again; scrollable insensitive result sets/cursors dont even need that."

The topic currently says, "A cursor declared to be held across commit can execute updates
and issue multiple commits before closing the cursor, but the cursor must be repositioned
before any statement following the commit. If this is attempted with auto-commit on, an error
is generated."

So I think you're saying that the last sentence here is not correct; so I've removed it. And
it looks as if the previous sentence would work if I change it as follows (it's kind of long
so I'm breaking it into two sentences): "A cursor declared to be held across commit can execute
updates and issue multiple commits before closing the cursor. A holdable forward-only cursor
must be repositioned before any statement following the commit." Would that be right?

And in the table I changed "Does not work" to say "Works for holdable cursors; does not work
for non-holdable cursors." 


I noticed that the SavepointJdbc30Test.java file mentioned in DERBY-3568 uses SQL SAVEPOINT
and RELEASE statements -- these aren't documented in the Derby Reference Manual. Neither are
COMMIT and ROLLBACK, for that matter. Is that omission deliberate? There's no JIRA for them.

> Remove JDBC 3.0-specific topics from Reference Manual and merge implementation notes
as needed
> ----------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3668
>                 URL: https://issues.apache.org/jira/browse/DERBY-3668
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Documentation
>    Affects Versions: 10.4.1.3
>            Reporter: Kim Haase
>            Assignee: Kim Haase
>            Priority: Minor
>         Attachments: DERBY-3668-2.diff, DERBY-3668-2.stat, DERBY-3668-2.zip, DERBY-3668.diff,
DERBY-3668.stat, DERBY-3668.zip
>
>
> The following files should be removed and their contents merged, where appropriate, with
the main files for the interfaces concerned. If implementation notes in the JDBC 3.0 topics
are identical to the javadoc (i.e. they are not really implementation notes), they can be
dropped.
> rrefjdbc32593.html ("JDBC 3.0 features"): remove.
> rrefjdbcjavasqlconnection30.html ("java.sql.Connection interface: supported JDBC 3.0
methods"): remove and merge implementation notes with rrefjdbc27734.html ("java.sql.Connection
interface") as needed. Only the last two items in the table contain implementation-specific
information.
> rrefjdbcdatabasemetadata30.html ("java.sql.DatabaseMetaData interface: supported JDBC
3.0 methods"): remove and merge implementation notes with rrefjdbc15905.html ("java.sql.DatabaseMetaData
interface") as needed. Only the last item in the table contains implementation-specific information.
> rrefjdbcparametermetadata30.html ("java.sql.ParameterMetaData interface: supported JDBC
3.0 methods"): remove. No need to create a topic for this interface in the general JDBC reference,
since there is no implementation-specific information for it.
> rrefjdbcjavasqlpreparedstatement30.html ("java.sql.PreparedStatement interface: supported
JDBC 3.0 methods"): remove. No implementation-specific information to merge.
> rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface") and its subtopics: This
is a somewhat complicated case. There is information in here that really belongs in the Developer's
Guide, I believe. I think this topic file should be moved up to the main JDBC reference section,
but its only contents should be the two Derby-specific restrictions described in rrefjavsaverestrict.html
("Restrictions on savepoints"). The topic rrefjavsaverestrict.html should then be removed,
since the rest of its contents are not implementation-specific. The substantive contents of
rrefjdbcjavasqlsavepoint.html ("java.sql.Savepoint interface"), crefjavsavesetroll.html ("Setting
and rolling back to a savepoint"), crefjavsaverel.html ("Releasing a savepoint"), and crefjavsaverules.html
("Rules for savepoints") could be combined into one topic and added to the Developer's Guide,
probably as an additional subtopic of "Transactions" under "The JDBC Connection and Transaction
Model", if that would make sense.
> rrefjdbcjavasqlstatement30.html ("java.sql.Statement interface: supported JDBC 3.0 methods"):
remove and merge implementation notes with rrefjdbc40794.html ("java.sql.Statement interface")
as needed. The subtopic crefjavstateautogen.html ("Autogenerated keys") should be made a subtopic
of rrefjdbc40794.html ("java.sql.Statement interface"), after the "ResultSet objects" topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message