Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 54686 invoked from network); 2 Apr 2008 17:41:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 2 Apr 2008 17:41:16 -0000 Received: (qmail 45198 invoked by uid 500); 2 Apr 2008 17:41:15 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 45162 invoked by uid 500); 2 Apr 2008 17:41:15 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 45153 invoked by uid 99); 2 Apr 2008 17:41:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2008 10:41:15 -0700 X-ASF-Spam-Status: No, hits=-1.0 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [192.18.43.133] (HELO sca-es-mail-2.sun.com) (192.18.43.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Apr 2008 17:40:22 +0000 Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m32HegJ5017861 for ; Wed, 2 Apr 2008 10:40:42 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JYP00E01J9UXL00@fe-sfbay-10.sun.com> (original mail from Richard.Hillegas@Sun.COM) for derby-dev@db.apache.org; Wed, 02 Apr 2008 10:40:42 -0700 (PDT) Received: from richard-hillegas-computer.local ([129.144.89.176]) by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTPSA id <0JYP001HHL3NX4B0@fe-sfbay-10.sun.com> for derby-dev@db.apache.org; Wed, 02 Apr 2008 10:40:35 -0700 (PDT) Date: Wed, 02 Apr 2008 10:40:37 -0700 From: Rick Hillegas Subject: Re: some comments on the 10.4 beta distribution In-reply-to: Sender: Richard.Hillegas@Sun.COM To: derby-dev@db.apache.org Message-id: <47F3C515.7000204@sun.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=ISO-8859-1 Content-transfer-encoding: 7BIT References: <47F14BCD.6020106@sun.com> User-Agent: Thunderbird 2.0.0.12 (Macintosh/20080213) X-Virus-Checked: Checked by ClamAV on apache.org Dyre.Tjeldvoll@Sun.COM wrote: > Rick Hillegas writes: > > >> I have downloaded the source distribution of the 10.4 beta and have a >> couple comments. After unpacking this distribution, I was able to >> build the docs and I was able to generate a release. The links from >> index.html worked. So the structure of the beta looks good to me. The >> release notes looked sketchy, but I've already sent mail about >> that. In addition, the following looked odd: >> >> o In the user guides, should "Copyright 2004-2007" be changed to >> "Copyright 2004-2008"? >> > > I can fix this. > > >> o The version number in the user documentation is 10.3, not 10.4 >> > > So I changed the *conrefs.dita files, but the version number in the pdfs > still says 10.3 (I don't know where to find the version number in the > html docs). What gives? > > >> o In the JDBC3 public api, there's a spurious line just before the >> title of the top-left frame. The line reads: 'Apache Derby 10.4 API >> Documentation">' >> > > I wonder if this is somehow related to the or > tag, for the javadoc target? > > executable="${javadocTool}" > classpath="${compile.classpath};${osgi};${servlet24};${out.dir}" > breakiterator="true" > destdir="${public.api.dir}" > Overview="${basedir}/published_api_overview.html" > Windowtitle="Apache Derby ${major}.${minor} API Documentation" > Header="Apache Derby ${major}.${minor}" > Footer="${javadoc.Footer}" > bottom="Apache Derby ${major}.${minor} API Documentation - <i& > gt;Copyright &copy; 2004,2008 The Apache Software Foundation. All Rights Res > erved.</i>"> > A > pache Derby ${major}.${minor} API Documentation]]> > > Any javadoc experts out there that would like to comment? > Well, I'm not going to present myself as a javadoc expert but here's my layman's theory: The exact same javadoc directive is used to build the jdbc3 and jdbc4 public apis. The spurious line turns up in the jdbc3 javadoc but not the jdbc4 javadoc. The jdbc3 javadoc is built with the Java 5 javadoc tool and the jdbc4 javadoc is built with the Java 6 javadoc tool. I think that the Java 5 javadoc tool may have a bug that was corrected in Java 6. What we're trying to do in this element is a bit tricky. We are trying to generate javadoc whose overview page has a title consisting of the Derby logo followed by some useful text. The element does not allow nested image elements, and we appear to have hacked around this by stuffing the image and text into a CDATA section. That CDATA section survives the Java 6 javadoc tool but is munged by the Java 5 javadoc tool. I can get rid of the spurious line at the cost of removing the Derby logo. That is, I get rid of the CDATA section and just put text inside the element like so: Apache Derby ${major}.${minor} API Documentation I miss the pretty logo, but I think that the output without the logo looks better than the output with both the logo and the spurious line. I can commit this change unless someone wants to put some more time into this problem in order to preserve the logo. Regards, -Rick > >> o The NOTICE file says "Copyright 2004-2007". Should that be changed >> to "Copyright 2004-2008"? >> > > Fixed by > dt136804@khepri32~/derby/derby-scratch$ svn log -r 637190 > ------------------------------------------------------------------------ > r637190 | djd | 2008-03-14 19:09:16 +0100 (Fri, 14 Mar 2008) | 1 line > > Update the ASF collected works copyright to be 2004-2008 in NOTICE and for the javadoc > ------------------------------------------------------------------------ > > (merged to 10.4) > >