Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <361589484.1207259004507.JavaMail.jira@brutus>
Date: Thu, 3 Apr 2008 14:43:24 -0700 (PDT)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3354) Select from large lob table with
 embedded gives OutOfMemoryError
In-Reply-To: <20467307.1201549894825.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585299#action_12585299 ] 

Kristian Waagan commented on DERBY-3354:
----------------------------------------

I haven't validated the approach, but it seems reasonable. I applied the patch and compiled Derby.

Some *very minor* things you can consider changing:
 1) Typos: "refrences" -> "references" (5 occurrences)
 2) Use of a space between the method call / declaration and the following parenthesis is not consistent.
 3) Trailing whitespace at diff lines 28, 107 and 148.
 4) You could change the comment for the weak hash map to JavaDoc.

Nice and small change :)
Is this the final patch, or are the more coming up?

> Select from large lob table with embedded gives OutOfMemoryError
> ----------------------------------------------------------------
>
>                 Key: DERBY-3354
>                 URL: https://issues.apache.org/jira/browse/DERBY-3354
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.3.1.4, 10.3.2.1, 10.4.0.0
>            Reporter: Kathey Marsden
>            Assignee: Anurag Shekhar
>         Attachments: derby-3354.diff, derby-3354_preview.diff, derby-3354_v1.diff, LocLeak.java
>
>
> Retrieving from a large table with lobs gives an OutOfMemoryException, even if free() is explictly called on the lob.   I believe this is because EmbedConnection.addLobMapping is called for every lob creation but is never cleared until commit or rollback, even if the lob is freed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.