db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta A. Satoor (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1201) ResultSet.updateRow() in network client should not throw an exception if no fields in the row have been modified.
Date Tue, 22 Apr 2008 05:35:21 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12591205#action_12591205
] 

Mamta A. Satoor commented on DERBY-1201:
----------------------------------------

It will be great if someone else can also look at the patch attached by Suran. 

>From my understanding, it looks like the change is good for embedded driver but I am not
sure about the change for client driver. 

>From Thomas's comment "The finalized JDBC 4.0 spec explicitly states that updateRow()
called on a ResultSet whos concurrency level is ResultSet.CONCUR_UPDATABLE, and without changes
to any row, will be treated as a no-op."  it appears that we should first make sure ResultSet
is ResultSet.CONCUR_UPDATABLE and if yes, then we should make updateRow() as no-op if no changes
were made. For client driver, the attached patch first checks if no changes were made and
if so, it simply returns from the method. It does not verify whether ResultSet. has ResultSet.CONCUR_UPDATABLE
set on it or not. In addition, the patch is removing the call checkForClosedResultSet(); from
updateRowX method. I am not sure if that change is ok or not. Maybe someone else knows for
sure.

> ResultSet.updateRow() in network client should not throw an exception if no fields in
the row have been modified.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-1201
>                 URL: https://issues.apache.org/jira/browse/DERBY-1201
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Client, Newcomer
>    Affects Versions: 10.1.1.0, 10.1.2.1, 10.1.3.1, 10.2.1.6
>            Reporter: David Van Couvering
>            Assignee: Suran Jayathilaka
>            Priority: Minor
>         Attachments: derby-1201.diff, TestUpdateRow.java
>
>
> ResultSet.updateRow() in the network client throws an exception if no fields in the current
row have been modified.  In the embedded client, the method silently does nothing in the same
circumstances.  Although the spec is yet to go final, our understanding is that JDBC 4 spec
indicates that the behavior of the embedded client is correct, so we should correct this in
the network client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message