Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <247597985.1206874644373.JavaMail.jira@brutus>
Date: Sun, 30 Mar 2008 03:57:24 -0700 (PDT)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Updated: (DERBY-3576) Merge EngineBlob and EngineClob into a
 single interface
In-Reply-To: <432776870.1206691224768.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/DERBY-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3576:
-----------------------------------

    Attachment: derby-3576-1b-enginelob_interface.diff

'derby-3576-1b-enginelob_interface.diff' is the same as 1a, except a comment is added to the EngineLOB class JavaDoc.

Bryan, what you describe is what I had in mind as well.
Unless I have misunderstood you, the difference between my current patch and your suggestion is that my patch removes the two unused interfaces whereas you're considering to keep them.

My thought was that since the two interfaces will be empty and there is no other code needing them, it was better to get rid of them. Introducing them later will take very little effort, and we also get the possibility of a discussion on whether they are required or not.
My main motivation behind the change in the first place, was that separating between Blob and Clob is not currently required and it complicates other work on the client.

For the record, large object handling through the interfaces discussed is very limited. They were introduced to support locators.

Normally I would wait for your reply on this one, but because the release candidate is getting very close and you say you have no objections to the current patch, I push forward and commit it.
Thank you for your comment!

> Merge EngineBlob and EngineClob into a single interface
> -------------------------------------------------------
>
>                 Key: DERBY-3576
>                 URL: https://issues.apache.org/jira/browse/DERBY-3576
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Network Server
>    Affects Versions: 10.4.0.0, 10.5.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3576-1a-enginelob_interface.diff, derby-3576-1a-enginelob_interface.stat, derby-3576-1b-enginelob_interface.diff
>
>
> There are currently two identical interfaces called EngineBlob and EngineClob.
> Merging these into a single interface would simplify some of the code handling Blob and Clob in the network server, and it also allows a leaner implementation of a stored procedure freeing LOB locators without knowing if the locator represents a Blob or a Clob.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.