Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 2757 invoked from network); 30 Mar 2008 22:56:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Mar 2008 22:56:45 -0000 Received: (qmail 83252 invoked by uid 500); 30 Mar 2008 22:56:44 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 83220 invoked by uid 500); 30 Mar 2008 22:56:44 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 83211 invoked by uid 99); 30 Mar 2008 22:56:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Mar 2008 15:56:44 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 30 Mar 2008 22:56:12 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A3A24234C0AE for ; Sun, 30 Mar 2008 15:54:24 -0700 (PDT) Message-ID: <1727417143.1206917664669.JavaMail.jira@brutus> Date: Sun, 30 Mar 2008 15:54:24 -0700 (PDT) From: "Erlend Birkenes (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-3568) Convert jdbcapi/savepointJdbc30_JSR169.java and jdbcapi/savepointJdbc30_XA.java to JUnit In-Reply-To: <1786944777.1206456084447.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erlend Birkenes updated DERBY-3568: ----------------------------------- Attachment: DERBY-3568_2.diff Here is my second attempt. - I moved database setup to CleanDatabaseSetup and decorateSQL so it only happens once. setUp() now only makes sure that AutoCommit is off. - I now keep everything local in the fixtures. - Instead of !TestUtil.isNetFramework() I now use usingEmbedded() in BaseJDBCTestCase. - I changed JCC to client in comments. - I now assertSQLState when catching exception. - I don't catch unexpected exceptions anymore. - Added the test to jdbcapi._Suite - Removed the test from the jdbcapi suite in the old harness - Removed masters. - Ran suites.All and derbyall. > Convert jdbcapi/savepointJdbc30_JSR169.java and jdbcapi/savepointJdbc30_XA.java to JUnit > ---------------------------------------------------------------------------------------- > > Key: DERBY-3568 > URL: https://issues.apache.org/jira/browse/DERBY-3568 > Project: Derby > Issue Type: Test > Components: Newcomer, Test > Reporter: Kathey Marsden > Assignee: Erlend Birkenes > Priority: Minor > Attachments: DERBY-3568.diff, DERBY-3568_2.diff > > > These are the last two in the jdk14 suite and might be a good beginner task. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.