db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Zaun (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3537) Invalid use shutdown authentication checks in NetworkServerControlImpl.directShutdown()
Date Wed, 19 Mar 2008 23:16:26 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580607#action_12580607
] 

Martin Zaun commented on DERBY-3537:
------------------------------------


Not 100% sure I understand your suggestion, but I think you mean changing
a) method NetworkServerControlImpl.directShutdownInternal()  from private to package access,
b) ClientThread to call parent.directShutdownInternal() instead of parent.directShutdown().

This would circumvent both checks, authentication and authorization (once it's enabled), for
a shutdown from ClientThread in case of an SSLException.

I don't think method NetworkServerControlImpl.directShutdown() can be made package-local,
since it's also invoked via reflection java.engine.org.apache.derby.iapi.jdbc.DRDAServerStarter.java.


> Invalid use shutdown authentication checks in NetworkServerControlImpl.directShutdown()

> ----------------------------------------------------------------------------------------
>
>                 Key: DERBY-3537
>                 URL: https://issues.apache.org/jira/browse/DERBY-3537
>             Project: Derby
>          Issue Type: Bug
>          Components: Network Server
>            Reporter: Daniel John Debrunner
>            Priority: Minor
>
> If ClientThread hits an SSLException exception it will call NetworkServerControlImpl.directShutdown().
> DERBY-2109 added privilege checking to directShutdown() that includes authentication.
> I can't see how this call by ClientThread can be valid. Authentication is not required
to start the network server, thus a NetworkServerControl with no user,password may be used
and thus passed onto directShutdown() failing authentication and then failing to perform the
failed shutdown?
> I think the error was adding the privilege check in DERBY-2109, it looks like this method
is for use only within the network server (actually this is the only use of it), maybe the
correct security mechanism would have been to make the method package private?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message