db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "V.Narayanan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3525) Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes
Date Thu, 13 Mar 2008 03:45:46 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578137#action_12578137

V.Narayanan commented on DERBY-3525:

I think it would be OK to move BrokeredConnection30 to the base class
BrokeredConnection since support for java 1.3 is not there anymore. But
I guess this change will cascade down to other 30 classes too which I
think would be out of scope for this issue and should maybe done in another

For now I think the patch attached to get rid of jdbcLevel should suffice.

> Remove unneeded code to get JDBC level in BrokeredConnection and BrokeredStatement classes
> ------------------------------------------------------------------------------------------
>                 Key: DERBY-3525
>                 URL: https://issues.apache.org/jira/browse/DERBY-3525
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC
>    Affects Versions:
>            Reporter: Knut Anders Hatlen
>            Assignee: Kathey Marsden
>            Priority: Minor
>         Attachments: derby-3525_diff.txt
> BrokeredConnection has a method called getJDBCLevel() whose only purpose is to provide
a value that can be stored in BrokeredStatement.jdbcLevel. This field is only used once, in
> 		if (jdbcLevel == 2)
> 			newStatement = conn.createStatement(resultSetType, resultSetConcurrency);
> 		else
> 			newStatement = conn.createStatement(resultSetType, resultSetConcurrency,
>                     resultSetHoldability);
> Since getJDBCLevel() only returns 2 if Java version 1.3 is used, and Derby doesn't support
Java 1.3 any more, BrokeredConnection.getJDBCLevel() and BrokeredStatement.jdbcLevel could
be removed.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message