db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kathey Marsden (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3568) Convert jdbcapi/savepointJdbc30_JSR169.java and jdbcapi/savepointJdbc30_XA.java to JUnit
Date Mon, 31 Mar 2008 13:46:29 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583688#action_12583688
] 

Kathey Marsden commented on DERBY-3568:
---------------------------------------

Thanks Erlend for the new patch. I am the one that suggested removing the old test, but I
guess that wasn't such a smart idea as it causes a build failure because the savepointJDbc30_XA
test still extends from it.
   [javac] Compiling 10 source files to C:\svn3\trunk\classes
   [javac] C:\svn3\trunk\java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\savepointJdbc30_XA.java:42:
c
nnot find symbol
   [javac] symbol: class savepointJdbc30_JSR169
   [javac] public class savepointJdbc30_XA  extends savepointJdbc30_JSR169{
   [javac]                                          ^
   [javac] C:\svn3\trunk\java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\savepointJdbc30_XA.java:62:
c
nnot find symbol
   [javac] symbol  : method runTests(java.lang.String,java.sql.Connection,java.sql.Connection)
   [javac] location: class org.apache.derbyTesting.functionTests.tests.jdbcapi.savepointJdbc30_XA
   [javac]             runTests("connections from XADataSource (local tranasaction)",
   [javac]                 ^
   [javac] C:\svn3\trunk\java\testing\org\apache\derbyTesting\functionTests\tests\jdbcapi\savepointJdbc30_XA.java:68:
c
nnot find symbol
   [javac] symbol  : method dumpSQLExceptions(java.sql.SQLException)
   [javac] location: class org.apache.derbyTesting.functionTests.tests.jdbcapi.savepointJdbc30_XA
   [javac]                 dumpSQLExceptions(e);
   [javac]                     ^
   [javac] 3 errors

Other comments.

I think we still have a problem that this won't run with network server.    You will have
to use the clientServerDecorator to get it to run with network server.  See CallableStatmentTest
for an example of how to use the clientServerDecorator and omit some tests for running with
client.

When creating statements, you can just use createStatement() instead of con.createStatement()
and then the statements will get closed automatically.

In decorateSQL, I think we can omit the code that tries to drop  the tables and catches  the
exception. I think we can assume a clean database.

I think in JDBCHarnessJavaTest we can just remove the savepointJdbc30_JSR169 line instead
of commenting it out.

All else looks good.

Kathey



> Convert jdbcapi/savepointJdbc30_JSR169.java and jdbcapi/savepointJdbc30_XA.java to JUnit
> ----------------------------------------------------------------------------------------
>
>                 Key: DERBY-3568
>                 URL: https://issues.apache.org/jira/browse/DERBY-3568
>             Project: Derby
>          Issue Type: Test
>          Components: Newcomer, Test
>            Reporter: Kathey Marsden
>            Assignee: Erlend Birkenes
>            Priority: Minor
>         Attachments: DERBY-3568.diff, DERBY-3568_2.diff
>
>
> These are the last two in the jdk14 suite and might be a good beginner task.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message