db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John H. Embretsen (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (DERBY-3385) Tests for JMX Management and Monitoring
Date Wed, 12 Mar 2008 13:12:50 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577839#action_12577839
] 

johnemb edited comment on DERBY-3385 at 3/12/08 6:12 AM:
-------------------------------------------------------------------

Attached patch file d3385_jdbcMBeanTest_02.diff:

M      java/testing/org/apache/derbyTesting/functionTests/tests/management/MBeanTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/management/JDBCMBeanTest.java
M      java/testing/org/apache/derbyTesting/junit/TestConfiguration.java
M      java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java
M      java/testing/org/apache/derbyTesting/junit/Utilities.java

This patch modifies the JDBCMBeanTest so that the expected values for the MajorVersion and
MinorVersion attributes are obtained from the embedded driver instead of the client driver.


I wasn't sure how to do this, but I ended up decorating these two test fixtures a bit differently
than the rest of the fixtures, by using a ServerSetup which JDBCClient is set to embedded.
The patch adds some logic in TestConfiguration.java and MBeanTest.java for handling this.

The patch also moves the two generic utility methods for fetching sysinfo output from MBeanTest.java
to org.apache.derbyTesting.junit.Utilities.java. In addition, the patch revises some Javadoc
comments in NetworkServerTestSetup.java.

When testing this patch I once ran into timeout issues similar to those reported in DERBY-3515
when running the management Suite on WinXP (single-CPU) - but I have not been able to reproduce
this yet, and it was likely not related to this specific patch - so I'm asking for review/commit
at this point.


      was (Author: johnemb):
    Attached patch file d3385_jdbcMBeanTest_02.diff:

M      java/testing/org/apache/derbyTesting/functionTests/tests/management/MBeanTest.java
M      java/testing/org/apache/derbyTesting/functionTests/tests/management/JDBCMBeanTest.java
M      java/testing/org/apache/derbyTesting/junit/TestConfiguration.java
M      java/testing/org/apache/derbyTesting/junit/NetworkServerTestSetup.java
M      java/testing/org/apache/derbyTesting/junit/Utilities.java

This patch modifies the JDBCMBeanTest so that the expected values for the MajorVersion and
MinorVersion attributes are obtained from the embedded driver instead of the client driver.


I wasn't sure how to do this, but I ended up decorating these two test fixtures a bit differently
than the rest of the fixtures, by using a NetworkServerTestSetup which JDBCClient is set to
embedded. The patch adds some logic in TestConfiguration.java and MBeanTest.java for handling
this.

The patch also moves the two generic utility methods for fetching sysinfo output from MBeanTest.java
to org.apache.derbyTesting.junit.Utilities.java. In addition, the patch revises some Javadoc
comments in NetworkServerTestSetup.java.

When testing this patch I once ran into timeout issues similar to those reported in DERBY-3515
when running the management Suite on WinXP (single-CPU) - but I have not been able to reproduce
this yet, and it was likely not related to this specific patch - so I'm asking for review/commit
at this point.

  
> Tests for JMX Management and Monitoring
> ---------------------------------------
>
>                 Key: DERBY-3385
>                 URL: https://issues.apache.org/jira/browse/DERBY-3385
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JMX, Test
>            Reporter: John H. Embretsen
>            Assignee: John H. Embretsen
>         Attachments: d3385_ant-junit-all.diff, d3385_jdbcMBeanTest_01.diff, d3385_jdbcMBeanTest_02.diff,
d3385_versionMBeanTest_01.diff, d3385_versionMBeanTest_02.diff, TestJMXp9.java
>
>
> DERBY-1387 implements a new feature set in Derby: Java Management eXtentions (JMX), i.e.
standards-based management and monitoring capabilities.
> As these are completely new features providing additional interfaces to a running Derby
system, a set of functional regression tests should be added. The new tests should verify
that Derby's public JMX API works as intended, and should be able to detect regressions in
this area in the future. There is a functional specification (jmxFuncspec.html) attached to
DERBY-1387 which may be used as reference.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message