db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3447) Shutdown on a database without stopping replication hangs
Date Wed, 26 Mar 2008 12:39:24 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582268#action_12582268

Øystein Grøvlen commented on DERBY-3447:

Thanks for the patch, Narayanan.  Changes look good, and my brief
testing shows that I am now able to quit ij when replication is
running.  However, it would be good if you could add some regression
tests for this issue to the replication test suite.

Before committing this patch, I want to get one question clarified:
In MasterController#stop, if stopMaster fails, you will still write
'Replication master role stopped for database' to derby.log.  Can you
be certain that this is the case regardless of what the error is?

Some nitpicks you may fix if you have to go another round with this

 - SlaveDatabase: I think sdbThread instead of sdb_Thread is more in
   line with the naming style used in the derby code.

 - MasterController: The casting to Thread does not seem to be

> Shutdown on a database without stopping replication hangs
> ---------------------------------------------------------
>                 Key: DERBY-3447
>                 URL: https://issues.apache.org/jira/browse/DERBY-3447
>             Project: Derby
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions:
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: Derby3447_v1.diff, Derby3447_v1.stat, Derby3447_v2.diff, Derby3447_v2.stat,
Derby3447_v3.diff, Derby3447_v3.stat, Derby3447_v4.diff, Derby3447_v4.stat

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message