db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Created: (DERBY-3490) Use defined constants (Java fields) in expected row data for getFunctionColumns in jdbc.TestDbMetaData test fixtures.
Date Mon, 03 Mar 2008 18:10:54 GMT
Use defined constants (Java fields) in expected row data for getFunctionColumns in jdbc.TestDbMetaData
test fixtures.
---------------------------------------------------------------------------------------------------------------------

                 Key: DERBY-3490
                 URL: https://issues.apache.org/jira/browse/DERBY-3490
             Project: Derby
          Issue Type: Improvement
          Components: Test
            Reporter: Daniel John Debrunner
            Priority: Minor


Use of numeric literals makes its impossible to figure out if the test is checking the correct
data. E.g.

Replace:
            { null, "APP", "DUMMY1", "", new Integer(4), new Integer(5),
              "SMALLINT", new Integer(5), new Integer(2), new Integer(0),
              new Integer(10), new Integer(1), null, null, new Integer(0),
              "YES", GENERIC_NAME, new Integer(1), new Integer(-1) },
with
            { null, "APP", "DUMMY1", "", DatabaseMetaData.functionReturn, Types.SMALLINT,

etc. (ie. replace 'new Integer' with defined constants where application)

Since this code is Java 6 auto-boxing can be used.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message