Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (athena.apache.org: domain of msatoor@gmail.com designates
 66.249.92.174 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=R0NKB/Sat39Kyxy0dsuQlRoswtQWgYsSH9xPA4cjGo5XKzfeiKuJEhB89HqZEMP5LFnw10vlTCK3xsnVN/Ho8mcn4NxxdNY6lbuN/g7NY4M9G7mWBQ4SdPs22sQDP6uNzgI1mI6gOm2btJ/qnKEJQNuUjrZPEICUC4sjrSPYM2M=
Message-ID: <d9619e4a0802150900i5556f12ap9213e34d868dbd8d@mail.gmail.com>
Date: Fri, 15 Feb 2008 09:00:58 -0800
From: "Mamta Satoor" <msatoor@gmail.com>
To: derby-dev@db.apache.org
Subject: Re: svn commit: r627673 -
 /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/LangProcedureTest.java
In-Reply-To: <d9619e4a0802140924x36878b65mb867feb7f1abe171@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080214062451.F229B1A9832@eris.apache.org>
	 <47B47600.80002@apache.org>
	 <d9619e4a0802140924x36878b65mb867feb7f1abe171@mail.gmail.com>

I will soon make a checkin for the resultset from the procedure which
shows that in trunk, after checkin 602991 for DERBY-1585, a procedure
does not return a resultset if there was a rollbck inside the
procedure with resultset creation before rollback. This behavior is
different than what happens in 10.2 codeline. In 10.2, a procedure
will return a *closed* resultset if there was a rollback inside the
procedure. From Dan's earlier comment in this thread([Note a procedure
does not return closed result sets]), it appears that trunk is
behaving correctly and 10.2's behavior was incorrect.

Mamta

On 2/14/08, Mamta Satoor <msatoor@gmail.com> wrote:
> Dan, you must have read my mind about dynamic resultset in my test
> case. I didn't on purpose add anything for that resultset because I am
> getting ready to file a jira entry for dynamic resultset and rollback
> inside java procedure. A rollback inside proc in 10.1 returns a closed
> dynamic resultset but the same thing in trunk returns a null object
> for dynamic resultset. I think I am very close to finding what commit
> caused this behavior. I need little more time to confirm that and then
> file a jira entry which will modify the test I have added
>
> Mamta
> On 2/14/08, Daniel John Debrunner <djd@apache.org> wrote:
> > mamta@apache.org wrote:
> > > Author: mamta
> > > Date: Wed Feb 13 22:24:50 2008
> > > New Revision: 627673
> > >
> > > URL: http://svn.apache.org/viewvc?rev=627673&view=rev
> > > Log:
> > > DERBY-3304 and DERBY-3414
> > > +            s
> > > +            .execute("create procedure procWithRollback(p1 int) parameter style JAVA READS SQL DATA dynamic result sets 1 language java external name 'org.apache.derbyTesting.functionTests.tests.lang.LangProcedureTest.rollbackInsideProc'");
> > > +            drs1 = prepareCall("CALL procWithRollback(3)");
> > > +            drs1.execute();
> > > +            rs = drs1.getResultSet();
> >
> > This fixture never asserts that the procedure does not return any result
> > sets. It fetches rs, but never does anything with it. Instead of
> > fetching rs, it should be using:
> >   JDBC.assertNoMoreResults(s);
> >
> > There's a chance though that it may require DERBY-3404 to be fixed first.
> >
> > [Note a procedure does not return closed result sets]
> >
> > Dan.
> >
>