Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <720162917.1203341674746.JavaMail.jira@brutus>
Date: Mon, 18 Feb 2008 05:34:34 -0800 (PST)
From: "Kristian Waagan (JIRA)" <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3425) J2EEDataSourceTest throws away stack
 trace for many errors
In-Reply-To: <24442732.1203181988590.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/DERBY-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569896#action_12569896 ] 

Kristian Waagan commented on DERBY-3425:
----------------------------------------

The changes look good to me.
They preserve the stack traces if an error occurs, and they also make the code cleaner.
I ran the test without failures with the patch applied.

+1 to commit

> J2EEDataSourceTest throws away stack trace for many errors
> ----------------------------------------------------------
>
>                 Key: DERBY-3425
>                 URL: https://issues.apache.org/jira/browse/DERBY-3425
>             Project: Derby
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Minor
>         Attachments: stack.diff
>
>
> Many of the test cases in J2EEDataSourceTest call fail() from within a catch block. Instead, they should just let the exception be thrown and let JUnit handle it. This way the stack trace will be preserved.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.