Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 81183 invoked from network); 1 Feb 2008 17:41:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Feb 2008 17:41:32 -0000 Received: (qmail 52014 invoked by uid 500); 1 Feb 2008 17:41:21 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 51952 invoked by uid 500); 1 Feb 2008 17:41:21 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 51861 invoked by uid 99); 1 Feb 2008 17:41:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2008 09:41:21 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2008 17:41:01 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 167BD714058 for ; Fri, 1 Feb 2008 09:41:09 -0800 (PST) Message-ID: <20025768.1201887669088.JavaMail.jira@brutus> Date: Fri, 1 Feb 2008 09:41:09 -0800 (PST) From: "A B (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-3376) Test case in GrantRevokeDDLTest looks to be accidentally commented out... In-Reply-To: <19557761.1201887668722.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A B updated DERBY-3376: ----------------------- Component/s: Test > Test case in GrantRevokeDDLTest looks to be accidentally commented out... > ------------------------------------------------------------------------- > > Key: DERBY-3376 > URL: https://issues.apache.org/jira/browse/DERBY-3376 > Project: Derby > Issue Type: Test > Components: Test > Affects Versions: 10.4.0.0 > Reporter: A B > Priority: Minor > > In lang/GrantRevokeDDLTest.java, beginning at line 8057 (at time of writing), there looks to be a test case that was inadvertently commented out: > // set connection user1 > //ij(USER3)> -- test multiple FKs DERBY-1589?set > // connection user1drop table user3.rt3drop table > // user2.rt2drop table user1.rt1create table rt1 (c1 int > // primary key not null, c2 int)insert into rt1 values > // (1,1), (2,2)grant references on rt1 to PUBLIC, user2, > // user3set connection user2 XJ001 occurred at create table > // rt2...create table rt2 (c1 int primary key not null, > // constraint rt2fk foreign key(c1) references > // user1.rt1)insert into rt2 values (1), (2)grant > // references on rt2 to PUBLIC, user3set connection > // user3create table rt3 (c1 int primary key not null, > // constraint rt3fk1 foreign key(c1) references > // user1.rt1, constraint rt3fk2 foreign key(c1) references > // user1.rt2)insert into rt3 values (1), (2)set connection > // user1 rt3fk1 should get dropped.revoke references on rt1 > // from PUBLICrevoke references on rt1 from user3set > // connection user2revoke references on rt2 from PUBLIC > // expect errorinsert into rt2 values (3)set connection > // user3 expect error, use user3 references privilege, > // rt3fk2 still in effectinsert into rt3 values (3)set > // connection user2revoke references on rt2 from user3set > // connection user3 ok, rt3fk2 should be dropped.insert > // into rt3 values (3) > Based on the format of the comment, my guess is that this JUnit test was created using the conversion script attached to DERBY-2151, and that the script somehow messed up the conversion. > The first line of the comment mentions DERBY-1589, but a) there is a question mark after it, and b) the commit for that issue does not appear to include the aforementioned lines. > If the test case is _supposed_ to be commented out, then some explanatory comments explaining why might be nice... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.