Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Message-ID: <15663414.1201876628718.JavaMail.jira@brutus>
Date: Fri, 1 Feb 2008 06:37:08 -0800 (PST)
From: =?utf-8?Q?J=C3=B8rgen_L=C3=B8land_=28JIRA=29?= <jira@apache.org>
To: derby-dev@db.apache.org
Subject: [jira] Commented: (DERBY-3205) Replication: Add connection url
 command options for starting, stopping slave and for failover
In-Reply-To: <20606458.1195128343797.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/DERBY-3205?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1256=
4782#action_12564782 ]=20

J=C3=B8rgen L=C3=B8land commented on DERBY-3205:
--------------------------------------

Thanks for committing the patch, =C3=98ystein.

> One thing that probably needs correction is the Javadoc of EmbedConnectio=
n#handleStopReplicationSlave which says "this operation will cause SlaveDat=
abase to call internalStopReplicationSlave". This doe not seem to be correc=
t.=20

I agree - the javadoc could be clearer. But it wil, in fact, cause SlaveDat=
abase to call internalStopReplicationSlave from the thread used to boot ser=
vices. After the thread in LogToFile.recover() is told to throw an exceptio=
n (LogToFile.stopReplicationSlaveMode), the exception is propagates all the=
 way down to SlaveDatabase and causes handleShutdown to be called.

> I do not understand your comment on 2e. about the TransactionResource nee=
ded to be cleaned. When you set up a new connection, don't you get a new Tr=
ansactionResource? If so, I do not understand why you need to create a new =
TransactionResource just to clean it.=20

I'm actually not sure about how the connection/transactionresource code wor=
ks. It could be the root connection that messes things up.

> Replication: Add connection url command options for starting, stopping sl=
ave and for failover
> -------------------------------------------------------------------------=
--------------------
>
>                 Key: DERBY-3205
>                 URL: https://issues.apache.org/jira/browse/DERBY-3205
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.4.0.0
>            Reporter: J=C3=B8rgen L=C3=B8land
>            Assignee: V.Narayanan
>         Attachments: derby-3205_startslave_dontcommit.diff, derby-3205_st=
artslave_dontcommit.stat, failover_impl_3205_NotForCommit_v1.diff, failover=
_impl_3205_NotForCommit_v1.stat, failover_impl_3205_v1.diff, failover_impl_=
3205_v1.stat, failover_impl_3205_v2.diff, failover_impl_3205_v2.stat, Socke=
t_Close_Fix_v1.diff, Socket_Close_Fix_v1.stat, startSlave_1a.diff, startSla=
ve_1a.stat, startSlave_1b.diff, startSlave_1b.stat, startSlave_1c.diff, sta=
rtSlave_1d.diff, StopSlave_impl_3205_NotForCommit_v1.diff, StopSlave_impl_3=
205_NotForCommit_v1.stat, stopSlave_v1a.diff, stopSlave_v1a.stat, stopSlave=
_v1b.diff, stopSlave_v1b.stat, stopSlave_v1c.diff, stopSlave_v1c.stat
>
>
> Add commands to start and stop the replication slave using properties or =
connection url. Example:
> 'jdbc:derby:<host><dbname>;startSlave=3Dtrue';
> 'jdbc:derby:<host><dbname>;stopSlave=3Dtrue';
> 'jdbc:derby:<host><dbname>;failover=3Dtrue;
> Connection url options that must be recognized:
> startSlave=3Dtrue
> stopSlave=3Dtrue
> failover=3Dtrue
> slaveHost=3D<host> (optional, defaults to localhost) (only for startSlave=
)
> slavePort=3D<port> (optional, defaults to 8001) (only for startSlave)
> See functional specification on Derby-2872 for further details.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.