Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 89498 invoked from network); 28 Feb 2008 22:48:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 28 Feb 2008 22:48:48 -0000 Received: (qmail 77175 invoked by uid 500); 28 Feb 2008 22:48:43 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 77148 invoked by uid 500); 28 Feb 2008 22:48:43 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 77139 invoked by uid 99); 28 Feb 2008 22:48:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Feb 2008 14:48:43 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Feb 2008 22:48:17 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 767BF234C040 for ; Thu, 28 Feb 2008 14:47:51 -0800 (PST) Message-ID: <127719748.1204238871484.JavaMail.jira@brutus> Date: Thu, 28 Feb 2008 14:47:51 -0800 (PST) From: "Daniel John Debrunner (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3452) ShutdownException and ErrorStringBuilder classes do not belong to the services context module In-Reply-To: <1510561116.1203725239995.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573500#action_12573500 ] Daniel John Debrunner commented on DERBY-3452: ---------------------------------------------- Applied patch Revision: 632129 with minor cleanup to correct the package names in the ASF licence header for the moved files. Thanks Dibyendu. I actually think the ErrorStringBuilder belongs in the iapi.services.streams module but in a slightly different form. A set of logical operations on InfoStreams that mirrored a sub-set of java.util.logging.Logger would provide benefits such as dynamic changing the level of the log information, including through standard JMX platform MBeans allowing other code to add handlers to Derby's logging etc. E.g. warning(), info(), config(), throwing() with the latter replacing the functionality of ErrorStringBuilder. I'll enter a new jira issue for this though. > ShutdownException and ErrorStringBuilder classes do not belong to the services context module > --------------------------------------------------------------------------------------------- > > Key: DERBY-3452 > URL: https://issues.apache.org/jira/browse/DERBY-3452 > Project: Derby > Issue Type: Sub-task > Reporter: Dibyendu Majumdar > Assignee: Dibyendu Majumdar > Attachments: DERBY-3452_patch_rev630512.txt > > > The classes ShutdownException and ErrorStringBuilder do not seem well placed in org.apache.derby.iapi.services.context as they are more about errors than about contexts. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.