From derby-dev-return-55010-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Thu Feb 14 12:19:29 2008 Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 30746 invoked from network); 14 Feb 2008 12:19:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Feb 2008 12:19:29 -0000 Received: (qmail 95153 invoked by uid 500); 14 Feb 2008 12:19:23 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 95122 invoked by uid 500); 14 Feb 2008 12:19:23 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 95113 invoked by uid 99); 14 Feb 2008 12:19:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2008 04:19:23 -0800 X-ASF-Spam-Status: No, hits=-1998.8 required=10.0 tests=ALL_TRUSTED,FS_REPLICA X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Feb 2008 12:19:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 199B671407B for ; Thu, 14 Feb 2008 04:19:08 -0800 (PST) Message-ID: <33212964.1202991548102.JavaMail.jira@brutus> Date: Thu, 14 Feb 2008 04:19:08 -0800 (PST) From: =?utf-8?Q?=C3=98ystein_Gr=C3=B8vlen_=28JIRA=29?= To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3382) Replication: Slave must inform master if DBs are out of sync. In-Reply-To: <21669427.1202121068877.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3382?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1256= 8907#action_12568907 ]=20 =C3=98ystein Gr=C3=B8vlen commented on DERBY-3382: ---------------------------------------- Comments to the 1a patch: 1. ReplicationMessageReceive#parseAndAckInstant: No need to inform the master in case of an unexpected message sequence? 2. MasterController: If and else parts is identical for both changes. I guess you are supposed to use getHighestShippedInstance() for the if-part. 3. AsynchronousLogShipper: I find the naming of ReplicationLogBuffer#getLastInstant() a bit confusing. I first wondered whether it represented the last instant added to the ReplicationLogBuffer, but I guess it is the last instant of the first chunk of the buffer. 4. LogToFile#getFlushedInstant: Looks very similar to getFirstUnflushedInstant except it returns a long instead of a LogCounter. However, the names seems to indicate that they are different. By the way, the latter is synchronized while the former is not. Is there a justification for that? > Replication: Slave must inform master if DBs are out of sync. > ------------------------------------------------------------- > > Key: DERBY-3382 > URL: https://issues.apache.org/jira/browse/DERBY-3382 > Project: Derby > Issue Type: Bug > Components: Replication > Affects Versions: 10.4.0.0 > Reporter: =C3=98ystein Gr=C3=B8vlen > Assignee: J=C3=B8rgen L=C3=B8land > Fix For: 10.4.0.0 > > Attachments: derby-3382-1a.diff, derby-3382-1a.stat > > > If I copy the database to the slave before booting the master, slave will= be out of sync with the master since new log records are created during bo= oting. The slave will then stop replication, but the master will not be no= tified. > If I then try to stop or failover the master the master will hang. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.