From derby-dev-return-54738-apmail-db-derby-dev-archive=db.apache.org@db.apache.org Mon Feb 11 16:30:30 2008 Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 67312 invoked from network); 11 Feb 2008 16:30:29 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 11 Feb 2008 16:30:29 -0000 Received: (qmail 24477 invoked by uid 500); 11 Feb 2008 16:30:22 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 24449 invoked by uid 500); 11 Feb 2008 16:30:22 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 24438 invoked by uid 99); 11 Feb 2008 16:30:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2008 08:30:22 -0800 X-ASF-Spam-Status: No, hits=-1998.8 required=10.0 tests=ALL_TRUSTED,FS_REPLICA X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2008 16:30:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 716F871407C for ; Mon, 11 Feb 2008 08:30:08 -0800 (PST) Message-ID: <12089808.1202747408462.JavaMail.jira@brutus> Date: Mon, 11 Feb 2008 08:30:08 -0800 (PST) From: =?utf-8?Q?=C3=98ystein_Gr=C3=B8vlen_=28JIRA=29?= To: derby-dev@db.apache.org Subject: [jira] Commented: (DERBY-3163) Derby JUnit test framework adaptions to run existing tests against replicated databases In-Reply-To: <8720585.1193755670895.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3163?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1256= 7687#action_12567687 ]=20 =C3=98ystein Gr=C3=B8vlen commented on DERBY-3163: ---------------------------------------- Thanks for the patch, Ole. 1. TestConfiguration: I see several questions and remarks like "This looks bogus" in comments that makes me a bit unsure about how ready this patch is. I think some of the comments should be cleaned up. 2. CleanDatabaseTestSetup:=20 a. The added constructor is as far as I can see, not used. Is future use planned? It is not clear to me when you would use this as opposed to the new methods in TestConfiguration. =20 b. Why are the added fields static? =20 c. setUp() contains two assignments to current. The first does not seem to serve any purpose since, if the variable is used, it will always be set a second time before it is used. =20 3. AnsiTrimTest/CreateTableFromQueryTest: It is not clear to me what the purpose of the refactoring of the statement executions is. Is this just preparing for future changes? 4. Minor nits:=20 a. Several lines are longer that 80 chars. =20 b. Code that is commented out. > Derby JUnit test framework adaptions to run existing tests against replic= ated databases > -------------------------------------------------------------------------= -------------- > > Key: DERBY-3163 > URL: https://issues.apache.org/jira/browse/DERBY-3163 > Project: Derby > Issue Type: Sub-task > Components: Test > Affects Versions: 10.4.0.0 > Reporter: Ole Solberg > Assignee: Ole Solberg > Priority: Minor > Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, = derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt > > > Extensions to run existing Apache Derby tests (old test harness tests ("d= erbyall" kind) > and junit tests) > This requires > - Running existing tests against already started servers on "non-localho= st" machines. > - verificationclients checking slave vs. master. > - ...=20 --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.