db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mamta Satoor" <msat...@gmail.com>
Subject Re: svn commit: r618788 - in /db/derby/code/trunk/java/engine/org/apache/derby/impl/sql: conn/GenericLanguageConnectionContext.java execute/BaseActivation.java
Date Wed, 06 Feb 2008 05:59:20 GMT
Actually, in the jira entry, DERBY-3304, I posted following comment
which is related to your question
************************************Comment copied from DERBY-3304************
As part of my committing the changes for this jira entry, I copied
some of the cleanup work(as shown below) from BaseActivation.reset
into new code in GenericLanguageConnectionContext.resetActivations
if (!a.isSingleExecution())

This code was always getting executed at the time of commit before my
commit and because of that, I decided to copy it in
GenericLanguageConnectionContext.resetActivations If anyone has any
comments on this, please let me know.
************************************End of comment copied from DERBY-3304******

I probably should have put this info in the commit comment. I will go
ahead and edit the commit comment.


On 2/5/08, Daniel John Debrunner <djd@apache.org> wrote:
> mamta@apache.org wrote:
> > Author: mamta
> > Date: Tue Feb  5 13:50:16 2008
> > New Revision: 618788
> > +                             a.clearHeapConglomerateController();
> > +                             if (!a.isSingleExecution())
> > +                                     a.clearWarnings();
> These lines seem to be new, not moved from reset().
> Could you explain why they are needed now and not before (or if I missed
> them being deleted from a another part of the diff).
> Thanks,
> Dan.

View raw message