db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2998) Add support for ROW_NUMBER() window function
Date Wed, 27 Feb 2008 04:26:53 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572781#action_12572781
] 

Daniel John Debrunner commented on DERBY-2998:
----------------------------------------------

AB> ... with patch 17. I'm not sure to what extent these need to be resolved before code
can be committed, as they (appear to) only occur when ROW_NUMBER() is in use and thus shouldn't
affect existing apps. But I'm not the one to say for sure one way or the other...

On the contrary, you *are* one of the ones to say if the patch should be committed. There
is no one authority, just a set of committers. If any committer has confidence in the patch
then she can commit it (and any other committer can veto it with a valid technical reason
if she thinks it should not be committed).

With a patch reaching its 17th iteration I think one has to consider if it should be committed
before too much of the effort is spent keeping the patch up to date with a moving codeline.

Is it better to keep trying to get a perfect patch (noting that the Derby project has ~450
open bugs so the base code is not perfect)?

Or is it better to get the code committed in some basic working state (has tests, doesn't
cause existing tests to fail) so that others can try it out *and* ongoing changes don't cause
regressions in the functionality.

And of course it's all done through svn, so reverting any patch is always an option.

> Add support for ROW_NUMBER() window function
> --------------------------------------------
>
>                 Key: DERBY-2998
>                 URL: https://issues.apache.org/jira/browse/DERBY-2998
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Thomas Nielsen
>            Assignee: Thomas Nielsen
>            Priority: Minor
>         Attachments: d2998-10.diff, d2998-10.stat, d2998-11.diff, d2998-12.diff, d2998-12.stat,
d2998-13.diff, d2998-13.stat, d2998-14.diff, d2998-14.stat, d2998-15.diff, d2998-15.stat,
d2998-16.diff, d2998-16.stat, d2998-17.diff, d2998-17.stat, d2998-4.diff, d2998-4.stat, d2998-5.diff,
d2998-5.stat, d2998-6.diff, d2998-6.stat, d2998-7.diff, d2998-7.stat, d2998-8.diff, d2998-8.stat,
d2998-9-derby.log, d2998-9.diff, d2998-9.stat, d2998-doc-1.diff, d2998-doc-1.stat, d2998-test.diff,
d2998-test.stat, d2998-test2.diff, d2998-test2.stat, d2998-test3.diff, d2998-test3.stat, d2998-test4.diff,
d2998-test4.stat, d2998-test6.diff, d2998-test7.diff
>
>
> As part of implementing the overall OLAP Operations features of SQL (DERBY-581), implement
the ROW_NUMBER() window function.
> More information about this feature is available at http://wiki.apache.org/db-derby/OLAPRowNumber

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message