db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3205) Replication: Add connection url command options for starting, stopping slave and for failover
Date Mon, 04 Feb 2008 09:37:07 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565295#action_12565295
] 

Øystein Grøvlen commented on DERBY-3205:
----------------------------------------

Thanks for the patch, Narayanan. v3 of the failover patch looks very good.
I have only a few minor comments.

1. EmbedConnection#handleFailover: There seems to be a cut&paste error
   for comment in handleFailover (talks about ready to start
   replication)

2. a. Exception javadocs:  A missing comment after "If the failover
      succeeds"
   b. I think you could use @see a bit more instead of repeating the
      javadoc.  Makes it less brittle if the behavior changes.

3. RawStore#failover: Use another version of newException to chain the
   caught exception, se, to the REPLICATION_FAILOVER_UNSUCCESSFUL
   exception.


> Replication: Add connection url command options for starting, stopping slave and for
failover
> ---------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3205
>                 URL: https://issues.apache.org/jira/browse/DERBY-3205
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: V.Narayanan
>         Attachments: derby-3205_startslave_dontcommit.diff, derby-3205_startslave_dontcommit.stat,
failover_impl_3205_NotForCommit_v1.diff, failover_impl_3205_NotForCommit_v1.stat, failover_impl_3205_v1.diff,
failover_impl_3205_v1.stat, failover_impl_3205_v2.diff, failover_impl_3205_v2.stat, failover_impl_3205_v3.diff,
failover_impl_3205_v3.stat, Socket_Close_Fix_v1.diff, Socket_Close_Fix_v1.stat, startSlave_1a.diff,
startSlave_1a.stat, startSlave_1b.diff, startSlave_1b.stat, startSlave_1c.diff, startSlave_1d.diff,
StopSlave_impl_3205_NotForCommit_v1.diff, StopSlave_impl_3205_NotForCommit_v1.stat, stopSlave_v1a.diff,
stopSlave_v1a.stat, stopSlave_v1b.diff, stopSlave_v1b.stat, stopSlave_v1c.diff, stopSlave_v1c.stat
>
>
> Add commands to start and stop the replication slave using properties or connection url.
Example:
> 'jdbc:derby:<host><dbname>;startSlave=true';
> 'jdbc:derby:<host><dbname>;stopSlave=true';
> 'jdbc:derby:<host><dbname>;failover=true;
> Connection url options that must be recognized:
> startSlave=true
> stopSlave=true
> failover=true
> slaveHost=<host> (optional, defaults to localhost) (only for startSlave)
> slavePort=<port> (optional, defaults to 8001) (only for startSlave)
> See functional specification on Derby-2872 for further details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message