db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3461) EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects and not a Derby specific implementation.
Date Thu, 28 Feb 2008 04:35:51 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573148#action_12573148
] 

Daniel John Debrunner commented on DERBY-3461:
----------------------------------------------

It's ok to leave the old versions of  the patch attached to the Jira issue, it allows reviewers
to compare patches to get an idea of what changed between them.

What did change in the patch that fixed a test failure? I was expecting to see a master file
(*.out) modified, but I didn't see one.

> EmbedSQLWarning should be renamed SQLWarningFactory and return java.sql.SQLWarning objects
and not a Derby specific implementation.
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3461
>                 URL: https://issues.apache.org/jira/browse/DERBY-3461
>             Project: Derby
>          Issue Type: Improvement
>          Components: JDBC, Services
>            Reporter: Daniel John Debrunner
>            Assignee: Dibyendu Majumdar
>            Priority: Minor
>         Attachments: DERBY-3461_patch_1_r631372.txt
>
>
> One side effect is that the toString() of such a warning would change format from starting
with "SQLWarning: " to "java.sql.SQLWarning: ", which should match any warnings created on
the network client side.
> See comments in DERBY-3453 as well for possible correct package of SQLWarningFactory.
> Note: generateCsSQLWarning() can be removed as it doesn't seem to be used.
> Note: Also SQLWarningFactory would not extend java.sql.SQLWarning.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message