db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel John Debrunner <...@apache.org>
Subject Re: svn commit: r627673 - /db/derby/code/trunk/java/testing/org/apache/derbyTesting/functionTests/tests/lang/LangProcedureTest.java
Date Thu, 14 Feb 2008 17:10:24 GMT
mamta@apache.org wrote:
> Author: mamta
> Date: Wed Feb 13 22:24:50 2008
> New Revision: 627673
> 
> URL: http://svn.apache.org/viewvc?rev=627673&view=rev
> Log:
> DERBY-3304 and DERBY-3414
> +            s
> +            .execute("create procedure procWithRollback(p1 int) parameter style JAVA
READS SQL DATA dynamic result sets 1 language java external name 'org.apache.derbyTesting.functionTests.tests.lang.LangProcedureTest.rollbackInsideProc'");
> +            drs1 = prepareCall("CALL procWithRollback(3)");
> +            drs1.execute();
> +            rs = drs1.getResultSet();

This fixture never asserts that the procedure does not return any result 
sets. It fetches rs, but never does anything with it. Instead of 
fetching rs, it should be using:
   JDBC.assertNoMoreResults(s);

There's a chance though that it may require DERBY-3404 to be fixed first.

[Note a procedure does not return closed result sets]

Dan.

Mime
View raw message