db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "A B (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-2998) Add support for ROW_NUMBER() window function
Date Wed, 27 Feb 2008 18:27:51 GMT

    [ https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12573011#action_12573011
] 

A B commented on DERBY-2998:
----------------------------

> Do you think that the approach I've taken is fundamentally flawed, or is it just being
too restrictive?

No, I do not think it's flawed.  And I can't say with any certainty that it's too restrictive,
either, as I haven't actually found any cases which prove that.  Maybe the failing queries
I posted above fall into that category, maybe not--I haven't done any detailed tracing.  I
thought I'd mention it as something which made me uneasy, but it could very well be fine as
it is.

> #3 - Patch 18 relaxes the expectancy of finding RCL->WindowFunction, as well as generalizing
> the conditions throughout. This fixes the failing count() queries.

I like the additional methods to distinguish between how/where to look for the WindowFunctionColumnNode.
Now the trick is to figure out which methods to call where :) My suggestion is that whenever
you call any of these methods, try to determine if a comment indicating why you chose the
method you did would be useful to the reader.  And that's especially true if you find yourself
switching from one method to another at any point...

Side note: looks like the new "isReferenceToOrWindowFunction()" for patch 18 is never actually
called anywhere. Was that intentional?

> Add support for ROW_NUMBER() window function
> --------------------------------------------
>
>                 Key: DERBY-2998
>                 URL: https://issues.apache.org/jira/browse/DERBY-2998
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Thomas Nielsen
>            Assignee: Thomas Nielsen
>            Priority: Minor
>         Attachments: d2998-10.diff, d2998-10.stat, d2998-11.diff, d2998-12.diff, d2998-12.stat,
d2998-13.diff, d2998-13.stat, d2998-14.diff, d2998-14.stat, d2998-15.diff, d2998-15.stat,
d2998-16.diff, d2998-16.stat, d2998-17.diff, d2998-17.stat, d2998-18.diff, d2998-18.stat,
d2998-4.diff, d2998-4.stat, d2998-5.diff, d2998-5.stat, d2998-6.diff, d2998-6.stat, d2998-7.diff,
d2998-7.stat, d2998-8.diff, d2998-8.stat, d2998-9-derby.log, d2998-9.diff, d2998-9.stat, d2998-doc-1.diff,
d2998-doc-1.stat, d2998-test.diff, d2998-test.stat, d2998-test2.diff, d2998-test2.stat, d2998-test3.diff,
d2998-test3.stat, d2998-test4.diff, d2998-test4.stat, d2998-test6.diff, d2998-test7.diff,
d2998-test8.diff
>
>
> As part of implementing the overall OLAP Operations features of SQL (DERBY-581), implement
the ROW_NUMBER() window function.
> More information about this feature is available at http://wiki.apache.org/db-derby/OLAPRowNumber

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message