db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1400) Cleanup code in network server's DRDAStatement class
Date Thu, 07 Feb 2008 15:14:09 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566628#action_12566628
] 

Kristian Waagan commented on DERBY-1400:
----------------------------------------

Not quite sure what you are asking about, but I'll try to help.

Regarding the patch, remove all changes that are not directly related to your cleanup of the
DRDAStatement code, like adding/removing/replacing spaces or tabs at places where you haven't
done any other change.

You should also run the tests to make sure you haven't broken anything. You can find instructions
and information at the wiki, and I think all the relevant pointers are in the following two
mail threads:
http://www.nabble.com/Derby-Testing-td15205194.html
http://www.nabble.com/Newbie-to-Derby-Testing-td15312500.html

I (or someone else ) will have another look at the updated patch after the unnecessary whitespace
changes have been removed.

I know running the tests can be a bit of a pain the first times, but it is something you have
to go through if you plan to contribute patches.


BTW: I noticed that the patch does not apply to trunk any more due to a conflicting change
in the same file. It also conflicts if I revert to the revision the patch was generated from
and then do svn up. So I think you might have to generate a new patch.

> Cleanup code in network server's DRDAStatement class
> ----------------------------------------------------
>
>                 Key: DERBY-1400
>                 URL: https://issues.apache.org/jira/browse/DERBY-1400
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Server, Newcomer
>    Affects Versions: 10.1.3.1, 10.2.1.6
>            Reporter: Deepa Remesh
>            Assignee: Abhilash T.G
>            Priority: Trivial
>         Attachments: DERBY-1400.diff
>
>
> The following cleanup tasks were identified as part of DERBY-1002 (http://issues.apache.org/jira/browse/DERBY-1002):
> * pkgcnstkn, pkgid, pkgsn variables can be removed from DRDAStatement since these are
derived from pkgnamcsn object.
> * Look into what is required by initialize() of default statement. Currently, initialize
just calls setTypDefValues(). Once the purpose of this method is confirmed, we may need to
modify the comments at places it is currently called.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message