db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3357) Reduce runtime of jdbcapi.DataSourceTest
Date Thu, 07 Feb 2008 20:13:10 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566773#action_12566773
] 

Daniel John Debrunner commented on DERBY-3357:
----------------------------------------------

Looks fine, minor comments:

 - minor concern that the name 'getRunTwiceSuite is confusing to me, implies that the fixtures
are run twice in a configuration. I think most other test classes use baseSuite() for a similar
purpose.

 -    In  testReadOnlyToWritableTran() it might be wise to expand this comment, I had to spend
time to figure out why only those two rows are being deleted.

+        // remove row 6 and 7 if previously committed

> Reduce runtime of jdbcapi.DataSourceTest
> ----------------------------------------
>
>                 Key: DERBY-3357
>                 URL: https://issues.apache.org/jira/browse/DERBY-3357
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Priority: Trivial
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3357-1a-lower_lock_timeout.diff, DERBY-3357_otherspeedup.diff
>
>
> Two tests in DataSoureTest are waiting for a lock timeout. The runtime of the suite could
be reduced by setting the lock timeout to a lower value.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message