db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3325) Add 'maxStatements' property to ClientConnectionPoolDataSource
Date Thu, 07 Feb 2008 15:32:14 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-3325:
-----------------------------------

    Attachment: derby-3325-1b-maxStatements.stat
                derby-3325-1b-maxStatements.diff

'derby-3325-1b-maxStatements.diff' is another attempt for introducing the maxStatements property
in ClientConnectionPoolDataSource.

A summary of the changes:

* loc/messages.xml
  Added one new message. Only added it for English (default locale).

* jdbc/ClientConnectionPoolDataSource.java
  Added methods set-/getMaxStatements and maxStatementsToPool.
  The latter is used internally by Derby to determine if caching is to be enabled. See ClientBaseDataSource.
  Also added a verification method used when de-serializing.

* jdbc/ClientBaseDataSource.java
  Added method maxStatementsToPool. Always returns 0 here, override in data source supporting
statement pooling.

* functionTests/tests/jdbcapi/ClientConnectionPoolDataSourceTest.java
  Added some very basic testing of the CCPDS.

* shared/common/reference/MessageId.java
  Added constant for the new error message.

* functionTests/tests/jdbcapi/DataSourceReferenceTest.java
  Updated the test to account for the newly introduced maxStatements property in CCPDS.

On a side note, I manually tested compatibility with regards to serialization. I have also
attached a patch testing serialization to DERBY-1318.

I have run the regression tests without failures with Sun JVM 1.4 and 1.5.


Patch ready for review.

> Add 'maxStatements' property to ClientConnectionPoolDataSource
> --------------------------------------------------------------
>
>                 Key: DERBY-3325
>                 URL: https://issues.apache.org/jira/browse/DERBY-3325
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: DataSourceReferenceTest.diff, DataSourceReferenceTest.java, derby-3325-1a-maxStatements.diff,
derby-3325-1a-maxStatements.stat, derby-3325-1b-maxStatements.diff, derby-3325-1b-maxStatements.stat
>
>
> The classes in Derby implementing javax.sql.ConnectionPoolDataSource must provide setter
and getter methods for the property 'maxStatements'.
> This property is used to control the whether the data source should produce pooled connections
with statement cache capabilities or not, and how big the statement cache is allowed to be.
> This issue only deals with the client JDBC driver.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message