db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Nielsen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2998) Add support for ROW_NUMBER() window function
Date Wed, 27 Feb 2008 15:47:54 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Nielsen updated DERBY-2998:
----------------------------------

    Attachment: d2998-test8.diff
                d2998-18.stat
                d2998-18.diff

Attaching patch 18 and test8.

To Armys comments:
#1 - Patch 18 fixes the comment in allExpressionsAreColumns()
#2 - No, there are no tests that check this. This is a relic from cloning IndexToBaseRowNode.
It should probably be removed?
#3 - Patch 18 relaxes the expectancy of finding RCL->WindowFunction, as well as generalizing
the conditions throughout. This fixes the failing count() queries.

The test8 patch add all additional queries pointed to by army to the OLAPTest. All but the
two last queries posted by Army pass, but I haven't had a chance to look at why yet. It is
most likely connected to comment #3 though.

Army> My experience with optimization/compilation is that VirtualColumnNodes, ResultColumns,
and 
Army> ColumnReferences are often stacked on top of each other in rather gratuitous fashion.

That's something I've obviously not taken well enough into consideration. Do you think that
the approach I've taken is fundamentally flawed, or is it just being too restrictive?

> Add support for ROW_NUMBER() window function
> --------------------------------------------
>
>                 Key: DERBY-2998
>                 URL: https://issues.apache.org/jira/browse/DERBY-2998
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Thomas Nielsen
>            Assignee: Thomas Nielsen
>            Priority: Minor
>         Attachments: d2998-10.diff, d2998-10.stat, d2998-11.diff, d2998-12.diff, d2998-12.stat,
d2998-13.diff, d2998-13.stat, d2998-14.diff, d2998-14.stat, d2998-15.diff, d2998-15.stat,
d2998-16.diff, d2998-16.stat, d2998-17.diff, d2998-17.stat, d2998-18.diff, d2998-18.stat,
d2998-4.diff, d2998-4.stat, d2998-5.diff, d2998-5.stat, d2998-6.diff, d2998-6.stat, d2998-7.diff,
d2998-7.stat, d2998-8.diff, d2998-8.stat, d2998-9-derby.log, d2998-9.diff, d2998-9.stat, d2998-doc-1.diff,
d2998-doc-1.stat, d2998-test.diff, d2998-test.stat, d2998-test2.diff, d2998-test2.stat, d2998-test3.diff,
d2998-test3.stat, d2998-test4.diff, d2998-test4.stat, d2998-test6.diff, d2998-test7.diff,
d2998-test8.diff
>
>
> As part of implementing the overall OLAP Operations features of SQL (DERBY-581), implement
the ROW_NUMBER() window function.
> More information about this feature is available at http://wiki.apache.org/db-derby/OLAPRowNumber

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message