db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jørgen Løland (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3205) Replication: Add connection url command options for starting, stopping slave and for failover
Date Fri, 01 Feb 2008 14:37:08 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564782#action_12564782
] 

Jørgen Løland commented on DERBY-3205:
--------------------------------------

Thanks for committing the patch, Øystein.

> One thing that probably needs correction is the Javadoc of EmbedConnection#handleStopReplicationSlave
which says "this operation will cause SlaveDatabase to call internalStopReplicationSlave".
This doe not seem to be correct. 

I agree - the javadoc could be clearer. But it wil, in fact, cause SlaveDatabase to call internalStopReplicationSlave
from the thread used to boot services. After the thread in LogToFile.recover() is told to
throw an exception (LogToFile.stopReplicationSlaveMode), the exception is propagates all the
way down to SlaveDatabase and causes handleShutdown to be called.

> I do not understand your comment on 2e. about the TransactionResource needed to be cleaned.
When you set up a new connection, don't you get a new TransactionResource? If so, I do not
understand why you need to create a new TransactionResource just to clean it. 

I'm actually not sure about how the connection/transactionresource code works. It could be
the root connection that messes things up.

> Replication: Add connection url command options for starting, stopping slave and for
failover
> ---------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3205
>                 URL: https://issues.apache.org/jira/browse/DERBY-3205
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.4.0.0
>            Reporter: Jørgen Løland
>            Assignee: V.Narayanan
>         Attachments: derby-3205_startslave_dontcommit.diff, derby-3205_startslave_dontcommit.stat,
failover_impl_3205_NotForCommit_v1.diff, failover_impl_3205_NotForCommit_v1.stat, failover_impl_3205_v1.diff,
failover_impl_3205_v1.stat, failover_impl_3205_v2.diff, failover_impl_3205_v2.stat, Socket_Close_Fix_v1.diff,
Socket_Close_Fix_v1.stat, startSlave_1a.diff, startSlave_1a.stat, startSlave_1b.diff, startSlave_1b.stat,
startSlave_1c.diff, startSlave_1d.diff, StopSlave_impl_3205_NotForCommit_v1.diff, StopSlave_impl_3205_NotForCommit_v1.stat,
stopSlave_v1a.diff, stopSlave_v1a.stat, stopSlave_v1b.diff, stopSlave_v1b.stat, stopSlave_v1c.diff,
stopSlave_v1c.stat
>
>
> Add commands to start and stop the replication slave using properties or connection url.
Example:
> 'jdbc:derby:<host><dbname>;startSlave=true';
> 'jdbc:derby:<host><dbname>;stopSlave=true';
> 'jdbc:derby:<host><dbname>;failover=true;
> Connection url options that must be recognized:
> startSlave=true
> stopSlave=true
> failover=true
> slaveHost=<host> (optional, defaults to localhost) (only for startSlave)
> slavePort=<port> (optional, defaults to 8001) (only for startSlave)
> See functional specification on Derby-2872 for further details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message