db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3421) Remove unused code for caching of connect bytes
Date Sat, 16 Feb 2008 15:49:08 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569583#action_12569583
] 

Knut Anders Hatlen commented on DERBY-3421:
-------------------------------------------

+1 to commit. It doesn't sound like an important feature, and if someone thinks it is, they
can always get the code back from svn and do what it takes to enable it. Since it's not used
now, it's better to remove it so that the code is easier to understand.

I think you can also remove NetConnectionReply.verifyDeferredReset() since you removed the
only code that calls it.

> Remove unused code for caching of connect bytes
> -----------------------------------------------
>
>                 Key: DERBY-3421
>                 URL: https://issues.apache.org/jira/browse/DERBY-3421
>             Project: Derby
>          Issue Type: Improvement
>          Components: Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>         Attachments: derby-3421-1a-removal.diff, derby-3421-1a-removal.stat
>
>
> The client driver has code for caching connect bytes, but it is not used.
> This unused code clutters the rest of the code and makes it harder to understand.
> Secondly, the variable used to determine if the cached connect bytes can be used is public
in am.Connection.
> If someone has historic information about this feature, it would be nice if they could
add the information to this Jira.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message