db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ole Solberg (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3163) Derby JUnit test framework adaptions to run existing tests against replicated databases
Date Tue, 12 Feb 2008 15:35:10 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Ole Solberg updated DERBY-3163:

    Attachment: derby-3163.1-v3.diff.txt

Thanks for looking at this patch, Øystein!

> Øystein Grøvlen commented on DERBY-3163:
> ----------------------------------------
> 1. TestConfiguration: I see several questions and remarks like "This
>    looks bogus" in comments that makes me a bit unsure about how ready
>    this patch is.  I think some of the comments should be cleaned up.

This was partly comments copy/pasted from "original" methods used as base 
for the variants needed when specifying host and port in a client/server
Cleaned up now.

> 2. CleanDatabaseTestSetup: 
>    a. The added constructor is as far as I can see, not used.  Is
>       future use planned?  It is not clear to me when you would use
>       this as opposed to the new methods in TestConfiguration.

It is for future use as in derby-3164.1-v1.diff.txt.

>    b. Why are the added fields static?  

Removed static.

>    c. setUp() contains two assignments to current.  The first does not
>       seem to serve any purpose since, if the variable is used, it
>       will always be set a second time before it is used.


> 3. AnsiTrimTest/CreateTableFromQueryTest: It is not clear to me what
>    the purpose of the refactoring of the statement executions is.  Is
>    this just preparing for future changes?

Yes, it is preparing  for 3164.
This is to be able to run existing JUnit tests in a replication context 
(specifying host and port in a client/server context).

derby-3164.1-v1.diff.txt defines a suite including a subset of the existing
JUnit tests for running in client/server context. 

Tests which use decorateSQL() must use networkclient when running setUp/decorateSQL
in this context.

> 4. Minor nits: 
>    a. Several lines are longer that 80 chars.  


>    b. Code that is commented out.



I will report back when tests are finished.

> Derby JUnit test framework adaptions to run existing tests against replicated databases
> ---------------------------------------------------------------------------------------
>                 Key: DERBY-3163
>                 URL: https://issues.apache.org/jira/browse/DERBY-3163
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions:
>            Reporter: Ole Solberg
>            Assignee: Ole Solberg
>            Priority: Minor
>         Attachments: derby-3163.1-v1.diff.txt, derby-3163.1-v2.diff.txt, derby-3163.1-v3.diff.txt,
derby-3163.2-v1.diff.txt, derby-3163.2-v2.diff.txt, derby-3163.2-v3.diff.txt
> Extensions to run existing Apache Derby tests (old test harness tests ("derbyall" kind)
>   and junit tests)
>   This requires
>  - Running existing tests against already started servers on "non-localhost" machines.
>  - verificationclients checking slave vs. master.
>  - ... 

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message