db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Nielsen (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-2998) Add support for ROW_NUMBER() window function
Date Fri, 29 Feb 2008 11:28:51 GMT

     [ https://issues.apache.org/jira/browse/DERBY-2998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Thomas Nielsen updated DERBY-2998:
----------------------------------

    Attachment: d2998-test9.diff
                d2998-19.stat
                d2998-19.diff

The hack that Army did really solves the fact that VCNs are wrong in the initial PRN when
there are window function columns in the PRNs child. I kept Armys 1)-3) changes, but removed
the hack and fixed it by regenerating the VCNs in PRN.modifyAccessPath(). This is done after
modifying the childResult *if* that modification ends with the PRNs child being PRN->WN
(meaning there are window functions in the childs RCL). This works fine, and I expect it to
actually solve other possible problems with later/further optimization too.

Attaching patch 19 and test9:
- fix as described above 
- some cleanup of unused methods and whitespace diffs
- test9 includes the last two join queries.

OLAPTest with test9 applied pass.
I'll run suites.All and derbyAll to make sure nothing else is broken.

> Add support for ROW_NUMBER() window function
> --------------------------------------------
>
>                 Key: DERBY-2998
>                 URL: https://issues.apache.org/jira/browse/DERBY-2998
>             Project: Derby
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Thomas Nielsen
>            Assignee: Thomas Nielsen
>            Priority: Minor
>         Attachments: d2998-10.diff, d2998-10.stat, d2998-11.diff, d2998-12.diff, d2998-12.stat,
d2998-13.diff, d2998-13.stat, d2998-14.diff, d2998-14.stat, d2998-15.diff, d2998-15.stat,
d2998-16.diff, d2998-16.stat, d2998-17.diff, d2998-17.stat, d2998-18.diff, d2998-18.stat,
d2998-19.diff, d2998-19.stat, d2998-4.diff, d2998-4.stat, d2998-5.diff, d2998-5.stat, d2998-6.diff,
d2998-6.stat, d2998-7.diff, d2998-7.stat, d2998-8.diff, d2998-8.stat, d2998-9-derby.log, d2998-9.diff,
d2998-9.stat, d2998-doc-1.diff, d2998-doc-1.stat, d2998-test.diff, d2998-test.stat, d2998-test2.diff,
d2998-test2.stat, d2998-test3.diff, d2998-test3.stat, d2998-test4.diff, d2998-test4.stat,
d2998-test6.diff, d2998-test7.diff, d2998-test8.diff, d2998-test9.diff
>
>
> As part of implementing the overall OLAP Operations features of SQL (DERBY-581), implement
the ROW_NUMBER() window function.
> More information about this feature is available at http://wiki.apache.org/db-derby/OLAPRowNumber

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message