db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Updated: (DERBY-3446) Make ResultSet.getStatemet return the correct statement when created by a logical statement
Date Fri, 22 Feb 2008 12:18:19 GMT

     [ https://issues.apache.org/jira/browse/DERBY-3446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kristian Waagan updated DERBY-3446:
-----------------------------------

    Attachment: derby-3446-2b_rs_getstatement_alternative.diff

Attached 'derby-3446-2b_rs_getstatement_alternative.diff'.

a) Actually, I had LogicalStatementEntity as an abstract class, until a tool told me it shouldn't
be because it didn't have any abstract methods. So I removed the abstract keyword and made
the constructor protected instead... I didn't let LSE implement java.sql.Statement, because
I saw no need for it (until now).

It does make sense with the current plan, and I have implemented approach a in patch 2b.
Thanks for the input :)

I'm also wondering if it would make sense to refer to the prepared statements as am.PreparedStatement,
since casts are starting to pop up in the code. Is the code a little too generic? This would
be handled in another issue though, and it needs to investigated.

> Make ResultSet.getStatemet return the correct statement when created by a logical statement
> -------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3446
>                 URL: https://issues.apache.org/jira/browse/DERBY-3446
>             Project: Derby
>          Issue Type: Task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3446-1a_rs_getstatement.diff, derby-3446-1a_rs_getstatement.stat,
derby-3446-2a_rs_getstatement_alternative.diff, derby-3446-2a_rs_getstatement_alternative.stat,
derby-3446-2b_rs_getstatement_alternative.diff
>
>
> ResultSet.getStatement must return the correct statement, that is the statement that
created the result set.
> It is particularly important for result set created by logical statements, as leaking
of physical statements can cause all kinds of side effects in a connection pooling environment.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message