db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John H. Embretsen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-1387) Add JMX extensions to Derby
Date Mon, 18 Feb 2008 15:10:35 GMT

    [ https://issues.apache.org/jira/browse/DERBY-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569921#action_12569921
] 

John H. Embretsen commented on DERBY-1387:
------------------------------------------

Some comments regarding (mainly) JMXManagementService.java:

1) Just to be clear: Is the reason why the unregisterMBean() method takes an
  Object instead of ObjectName as parameter that it should be possible to 
  call this method from code compiled with jdk1.4? (Same goes for the 
  return type of registerMBean)

2) The following javadoc comment for registerMBean() now seems outdated:

   * The object name instance 
   * represented by the given String will be created by this method.
  
3) I think the current use of the term "attribute" in registerMBean() has 
  potential to confuse people. In JMX land, the term "attribute" denotes the 
  MBean properties that are exposed through getter and setter methods. In
  JMXManagementService.java, the term "attribute" or "nameAttribute" is also
  used for the key properties of an ObjectName, for example "type=Version" 
  or "jar=derby.jar".
  I think using a different term for the latter will make it easier for
  other people to get acquainted with this code. Official JMX documentation
  (e.g. the ObjectName javadocs) refers to these properties as 
  "Key properties", an unordered set of keys and associated values, so 
  perhaps it is better to use that term instead?

4) Is it true that Monitor.getSystemModule(Module.JMX) will never return null,
  if we keep the current implementation?


> Add JMX extensions to Derby
> ---------------------------
>
>                 Key: DERBY-1387
>                 URL: https://issues.apache.org/jira/browse/DERBY-1387
>             Project: Derby
>          Issue Type: New Feature
>          Components: Services
>            Reporter: Sanket Sharma
>            Assignee: John H. Embretsen
>         Attachments: DERBY-1387-1.diff, DERBY-1387-1.stat, DERBY-1387-2.diff, DERBY-1387-2.stat,
DERBY-1387-3.diff, DERBY-1387-3.stat, DERBY-1387-4.diff, DERBY-1387-4.stat, DERBY-1387-5.diff,
DERBY-1387-5.stat, DERBY-1387-6.zip, DERBY-1387-7.zip, DERBY-1387-8.zip, DERBY-1387-9.diff,
DERBY-1387-9.stat, derby1387_simple_9_1.txt, derbyjmx.patch, jmx.diff, jmx.stat, jmxFuncspec.html,
jmxFuncspec.html, jmxFuncspec.html, Requirements for JMX Updated.html, Requirements for JMX.html,
Requirements for JMX.zip
>
>
> This is a draft requirement specification for adding monitoring and management extensions
to Apache Derby using JMX. The requirements document has been uploaded on JIRA as well as
the Derby Wiki page at http://wiki.apache.org/db-derby/_Requirement_Specifications_for_Monitoring_%26_Management_Extensions_using_JMX
> Developers and Users are requested to please look at the document (feature list in particular)
and add their own rating to features by adding a coloumn to the table.
> Comments are welcome.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message