db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kristian Waagan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3325) Add 'maxStatements' property to ClientConnectionPoolDataSource
Date Mon, 04 Feb 2008 10:47:12 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12565302#action_12565302
] 

Kristian Waagan commented on DERBY-3325:
----------------------------------------

Thanks for the comments you gave on the 23rd of January, Knut Anders.

Regarding the getMaxStatements method, I discovered that I can't just add the getter to ClientBaseDataSource,
as it breaks the JavaBean specification and causes an NPE in the JVM when using Referenceable.
I will incorporate your suggestion, but rename the method to something else ('maxStatementsToPool'?)
and add get-/setMaxStatements to ClientConnectionPoolDataSource only.
For CBDS the method will return 0, for CCPDS it will return maxStatements.

I'll fix the typos, and enable the tests.

I logged DERBY-3306 a while ago for the bug in the framework regarding data sources, but it
is for a specific test and not for the general problem. I do plan to use another mechanism
in my tests (a decorator, see DERBY-3326), and the problem will go away.

Will change test to use the assert method.

I hope to post a new patch within a few days.

> Add 'maxStatements' property to ClientConnectionPoolDataSource
> --------------------------------------------------------------
>
>                 Key: DERBY-3325
>                 URL: https://issues.apache.org/jira/browse/DERBY-3325
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: DataSourceReferenceTest.diff, DataSourceReferenceTest.java, derby-3325-1a-maxStatements.diff,
derby-3325-1a-maxStatements.stat
>
>
> The classes in Derby implementing javax.sql.ConnectionPoolDataSource must provide setter
and getter methods for the property 'maxStatements'.
> This property is used to control the whether the data source should produce pooled connections
with statement cache capabilities or not, and how big the statement cache is allowed to be.
> This issue only deals with the client JDBC driver.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message