Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 92835 invoked from network); 8 Jan 2008 21:38:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Jan 2008 21:38:43 -0000 Received: (qmail 12164 invoked by uid 500); 8 Jan 2008 21:38:32 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 12135 invoked by uid 500); 8 Jan 2008 21:38:32 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 12126 invoked by uid 99); 8 Jan 2008 21:38:32 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2008 13:38:32 -0800 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [69.147.64.96] (HELO smtp123.sbc.mail.sp1.yahoo.com) (69.147.64.96) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 08 Jan 2008 21:38:20 +0000 Received: (qmail 75028 invoked from network); 8 Jan 2008 21:38:11 -0000 Received: from unknown (HELO ?192.168.254.144?) (ddebrunner@sbcglobal.net@75.24.108.32 with plain) by smtp123.sbc.mail.sp1.yahoo.com with SMTP; 8 Jan 2008 21:38:10 -0000 X-YMail-OSG: RGJl7AYVM1nCIYdAh3To0_4DyuO8hfJ1wBzQsXDxMLKw.7wdxIe80Y02PSBd6Dt2lmAg5UTH8su7iEyahHwLAPwSSVZ13pjXf2z_VX9DNGB9cQGD_1aZOTA1TX5x Message-ID: <4783ED43.70709@apache.org> Date: Tue, 08 Jan 2008 13:38:11 -0800 From: Daniel John Debrunner User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: derby-dev@db.apache.org Subject: Re: Bug, or can the code be deleted/commented? (SQLChar) References: <47834785.4070907@Sun.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Knut Anders Hatlen wrote: > Kristian Waagan writes: > >> Hello, >> >> While fiddling around in the source code, I came across the following >> piece of code in iapi.types.SQLChar: >> >> protected void copyState(SQLChar other) { >> >> this.value = other.value; >> this.rawData = other.rawData; >> this.rawLength = other.rawLength; >> this.cKey = other.cKey; >> this.stream = other.stream; >> this.intArray = intArray; >> this.intLength = intLength; >> this.localeFinder = localeFinder; >> } >> >> >> Note that the three last assignments are assignments to self. >> Is this a bug, or is it intentional? I think those fields (intArray, intLength, localFinder) are dead code, see DERBY-2720. http://issues.apache.org/jira/browse/DERBY-2720 Dan.