Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm
Precedence: bulk
Reply-To: <derby-dev@db.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Date: Tue, 08 Jan 2008 10:51:01 +0100
From: Kristian Waagan <Kristian.Waagan@Sun.COM>
Subject: Bug, or can the code be deleted/commented? (SQLChar)
Sender: Kristian.Waagan@Sun.COM
To: Derby Development <derby-dev@db.apache.org>
Message-id: <47834785.4070907@Sun.com>
Organization: Sun Microsystems Inc.
MIME-version: 1.0
Content-type: text/plain; format=flowed; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
User-Agent: Mozilla/5.0 (X11; U; SunOS i86pc; no-NO;
 rv:1.8.1.9) Gecko/20071119
 Thunderbird/2.0.0.9 Mnenhy/0.7.5.0

Hello,

While fiddling around in the source code, I came across the following 
piece of code in iapi.types.SQLChar:

	protected void copyState(SQLChar other) {

		this.value = other.value;
		this.rawData = other.rawData;
		this.rawLength = other.rawLength;
		this.cKey = other.cKey;
		this.stream = other.stream;
		this.intArray = intArray;
		this.intLength = intLength;
		this.localeFinder = localeFinder;
	}


Note that the three last assignments are assignments to self.
Is this a bug, or is it intentional?

If it is intentional, my opinion is that the lines should be deleted and 
replaced by a comment (or at least commented out and be accompanied by a 
suitable text comment).


thanks,
-- 
Kristian