Return-Path: Delivered-To: apmail-db-derby-dev-archive@www.apache.org Received: (qmail 18413 invoked from network); 23 Jan 2008 12:31:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Jan 2008 12:31:59 -0000 Received: (qmail 23142 invoked by uid 500); 23 Jan 2008 12:31:49 -0000 Delivered-To: apmail-db-derby-dev-archive@db.apache.org Received: (qmail 23106 invoked by uid 500); 23 Jan 2008 12:31:49 -0000 Mailing-List: contact derby-dev-help@db.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: Delivered-To: mailing list derby-dev@db.apache.org Received: (qmail 23097 invoked by uid 99); 23 Jan 2008 12:31:49 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jan 2008 04:31:49 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Jan 2008 12:31:43 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 5FEAB71420B for ; Wed, 23 Jan 2008 04:31:35 -0800 (PST) Message-ID: <14524631.1201091495390.JavaMail.jira@brutus> Date: Wed, 23 Jan 2008 04:31:35 -0800 (PST) From: "Kristian Waagan (JIRA)" To: derby-dev@db.apache.org Subject: [jira] Updated: (DERBY-3308) Broken synchronization for event handling in ClientPooledConnection40 In-Reply-To: <10628794.1199884534136.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/DERBY-3308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristian Waagan updated DERBY-3308: ----------------------------------- Attachment: derby-3308-1a-eventlisteners_synchronization.diff 'derby-3308-1a-eventlisteners_synchronization.diff' synchronizes all methods accessing the list (a java.util.Vector) of statement event listeners. I ran derbyall/suites.All without errors. Patch ready for review. > Broken synchronization for event handling in ClientPooledConnection40 > --------------------------------------------------------------------- > > Key: DERBY-3308 > URL: https://issues.apache.org/jira/browse/DERBY-3308 > Project: Derby > Issue Type: Bug > Components: JDBC, Network Client > Affects Versions: 10.2.2.0, 10.3.2.1, 10.4.0.0 > Reporter: Kristian Waagan > Assignee: Kristian Waagan > Priority: Minor > Fix For: 10.4.0.0 > > Attachments: derby-3308-1a-eventlisteners_synchronization.diff > > > Access to the the list of event listeners is not synchronized properly. > Taken the rather infrequent use of the relevant methods and the small critical sections, I mean it is sufficient to add synchronization to all the methods that access it at the method level. The same approach is taken in ClientPooledConnection (although not followed through consistently, some of the methods are unsynchronized). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.