db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel John Debrunner (JIRA)" <j...@apache.org>
Subject [jira] Commented: (DERBY-3325) Add 'maxStatements' property to ClientConnectionPoolDataSource
Date Wed, 23 Jan 2008 15:53:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561719#action_12561719
] 

Daniel John Debrunner commented on DERBY-3325:
----------------------------------------------

+            throw new IllegalArgumentException("Negative values for max " +
+                    "statements are not allowed: " + maxStatements);

There seems to be a worrying trend of adding English only, non-localized messages. Derby has
always used localization for almost all error messages, ClientBaseDataSource already has a
couple of localized exceptions, any reason not to use the mechanism here?

Not sure I understand the comment avoid avoiding casts in the factory methods. Why would the
factory methods care about max statements, won't the logic of statement pooling be self-contained
in either the pooling data source or pooling connection? Is there another patch that shows
this?

Since we are adding a field to a serializable class are there any issues around that? Ie.
10.0 data sources serialized need to be unserialized correctly with 10.4 code.

XA can support statement pooling, XAConnection extends PooledConnection, therefore it inherits
all the behaviour of PooledConnection and thus section 11.6 of JDBC 4 spec applies to XA.
If your own itch is just non-XA data sources then that's fine.

> Add 'maxStatements' property to ClientConnectionPoolDataSource
> --------------------------------------------------------------
>
>                 Key: DERBY-3325
>                 URL: https://issues.apache.org/jira/browse/DERBY-3325
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>            Priority: Minor
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3325-1a-maxStatements.diff, derby-3325-1a-maxStatements.stat
>
>
> The classes in Derby implementing javax.sql.ConnectionPoolDataSource must provide setter
and getter methods for the property 'maxStatements'.
> This property is used to control the whether the data source should produce pooled connections
with statement cache capabilities or not, and how big the statement cache is allowed to be.
> This issue only deals with the client JDBC driver.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message