db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kristian Waagan <Kristian.Waa...@Sun.COM>
Subject Bug, or can the code be deleted/commented? (SQLChar)
Date Tue, 08 Jan 2008 09:51:01 GMT

While fiddling around in the source code, I came across the following 
piece of code in iapi.types.SQLChar:

	protected void copyState(SQLChar other) {

		this.value = other.value;
		this.rawData = other.rawData;
		this.rawLength = other.rawLength;
		this.cKey = other.cKey;
		this.stream = other.stream;
		this.intArray = intArray;
		this.intLength = intLength;
		this.localeFinder = localeFinder;

Note that the three last assignments are assignments to self.
Is this a bug, or is it intentional?

If it is intentional, my opinion is that the lines should be deleted and 
replaced by a comment (or at least commented out and be accompanied by a 
suitable text comment).


View raw message