db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3254) Implement the replication failover functionality
Date Thu, 03 Jan 2008 10:05:34 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12555521#action_12555521
] 

Øystein Grøvlen commented on DERBY-3254:
----------------------------------------

Thanks for the patch, Narayanan.  My main question about this patch is
about failure handling during failover.  If failover is not
successful, I think the current master should continue as master.
Also, I am not sure that just being able to send the failover message
is sufficient to decide that failover was successful.  Maybe some
acknowledgement from the slave is needed?

As it is, the implementation of stop and failover is identical at the
slave.  I guess it is the implementation of stop that is missing
something?

Some minor issues:

  - LogToFile#stopReplicationSlaveRole(): I think the javadoc here is
    a bit inaccurate.  AFAIU, setting the inReplicationSlaveMode flag
    will make the slave complete recovery and boot the database.

  - There is a double ; in SlaveController#failover.

  - I think a successful failover should also be recorded in derby.log
    also at the (former) slave.

  - There is a typo in the message text for R011: "perfomed"
  


> Implement the replication failover functionality
> ------------------------------------------------
>
>                 Key: DERBY-3254
>                 URL: https://issues.apache.org/jira/browse/DERBY-3254
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: failover_impl_notforcommit.diff, failover_impl_notforcommit.stat,
failover_impl_v1.diff, failover_impl_v1.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message