db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3254) Implement the replication failover functionality
Date Wed, 16 Jan 2008 12:01:06 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559458#action_12559458
] 

Øystein Grøvlen commented on DERBY-3254:
----------------------------------------

Thanks for the patch, Narayanan.  Her are my comments:

1. Instead of using Database#freeze, think you should use
   RawStoreFactory#freeze since MasterController relates to the store,
   and not the SQL layer.  This also removes the need for importing
   SQLException.

2. Maybe I am wrong, but it seems to me that you are shutting down the
   entire system.  At least, you do not specify which database to shut
   down.  Instead of an explicit shutdown, I think you should consider
   to just use database severity for the exception you throw.  I think
   that will make the connection close down the database
   automatically.

3. MasterController#handleFailoverFailure:  Don't you mean to use
   REPLICATION_FAILOVER_UNSUCCESSFUL also for the else part?

4. Some of my comments to the previous version of the patch does not
   seem to have been addressed.
 


> Implement the replication failover functionality
> ------------------------------------------------
>
>                 Key: DERBY-3254
>                 URL: https://issues.apache.org/jira/browse/DERBY-3254
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: failover_impl_notforcommit.diff, failover_impl_notforcommit.stat,
failover_impl_v1.diff, failover_impl_v1.stat, failover_impl_v2.diff, failover_impl_v2.stat,
failover_impl_v3.diff, failover_impl_v3.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message