db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Knut Anders Hatlen <Knut.Hat...@Sun.COM>
Subject Re: copy&paste bug in BaseMonitor?
Date Sat, 01 Dec 2007 17:05:11 GMT
Martin Zaun <Martin.Zaun@Sun.COM> writes:

> Hi,
> a particular line of code
>   java/engine/org/apache/derby/impl/services/monitor/BaseMonitor.java:1086
> very much looks like a copy&paste bug to me:
>
>     private Vector getImplementations(Properties moduleList, boolean actualModuleList)
{
>             ...
>             if (key.startsWith(Property.MODULE_PREFIX)) {
>                 tag = key.substring(Property.MODULE_PREFIX.length());
>             } else if (key.startsWith(Property.SUB_SUB_PROTOCOL_PREFIX)) {
>                 tag = key.substring(Property.MODULE_PREFIX.length());
>                                              ^^^^^^^^^^^^^
>             } ...
>
> I guess MODULE_PREFIX was meant to be replaced with SUB_SUB_PROTOCOL_PREFIX.
>
> Comments?

Hi Martin,

I agree that it looks like a bug. Seems like it was introduced by one of
the check-ins for DERBY-927, which is still open. Perhaps you could add
a comment on that issue.

-- 
Knut Anders

Mime
View raw message