db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Øystein Grøvlen (JIRA) <j...@apache.org>
Subject [jira] Commented: (DERBY-3235) Implement the replication stop functionality
Date Mon, 17 Dec 2007 15:13:43 GMT

    [ https://issues.apache.org/jira/browse/DERBY-3235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552435
] 

Øystein Grøvlen commented on DERBY-3235:
----------------------------------------

Thanks for the patch Narayanan.  It looks good. Will there be more
code coming for clean-up of the slave?  (I see there is a todo tag in
StopSlave, but I am not quite sure what needs to be done.)

Why is AsynchronousLogShipper#flushBuffer not synchronized while
shipALogChunk is?  Another question is whether these two methods could
share some code.  Could flushBuffer be implemented as
"while(shipALogChunk());"?

One minor issue:  Javadoc for stopMaster() says that it throws
StandardException.  It does not.



> Implement the replication stop functionality
> --------------------------------------------
>
>                 Key: DERBY-3235
>                 URL: https://issues.apache.org/jira/browse/DERBY-3235
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Replication
>    Affects Versions: 10.4.0.0
>            Reporter: V.Narayanan
>            Assignee: V.Narayanan
>         Attachments: StopImplementation_v1.diff, StopImplementation_v1.stat, StopImplementation_v1_NotForCommit.diff,
StopImplementation_v1_NotForCommit.stat
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message