db-derby-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Knut Anders Hatlen (JIRA)" <j...@apache.org>
Subject [jira] Created: (DERBY-3275) Mismatch between comments and actual use of initialSize parameter in CacheFactory and Clock
Date Fri, 14 Dec 2007 10:11:43 GMT
Mismatch between comments and actual use of initialSize parameter in CacheFactory and Clock
-------------------------------------------------------------------------------------------

                 Key: DERBY-3275
                 URL: https://issues.apache.org/jira/browse/DERBY-3275
             Project: Derby
          Issue Type: Bug
          Components: Services
    Affects Versions: 10.4.0.0
            Reporter: Knut Anders Hatlen
            Priority: Minor


The javadoc for org.apache.derby.iapi.services.cache.CacheFactory.newCacheManager() describes
the initialSize parameter like this:

		@param initialSize	The number of initial holder objects that will be created

And org.apache.derby.impl.services.cache.Clock's constructor says the following:

		@param initialSize the initial number of cachable object this cache
		holds.
		@param maximumSize the maximum size of the cache.  The cache may grow
		from initialSize to maximumSize if the cache policy notices that there
		is not enough free buffers availiable.  Once the cache hits maximumSize
		it will not grow.  If the cache is full, an exception will be thrown

However, when Clock is created, it does not populate the cache with "holder objects" or "cacheable
[objects]". It only uses the initialSize to specify the initial capacity of the HashMap and
the ArrayList that are created.

Either the code should be changed so that it's in line with the comments, or the comments
should be changed to match the code. I don't see any compelling reason for changing the code,
so I think I would prefer changing the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message